Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1220)

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 2722273002: Add Select All to Android floating insertion menu (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/content_view_core_impl.cc
diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc
index 1efb3283987649d8573c19c13f9c7e9457f97038..b6e9e2121efa69b683837c1258a8766832175759 100644
--- a/content/browser/android/content_view_core_impl.cc
+++ b/content/browser/android/content_view_core_impl.cc
@@ -53,6 +53,7 @@
#include "jni/ContentViewCore_jni.h"
#include "jni/DragEvent_jni.h"
#include "third_party/WebKit/public/platform/WebInputEvent.h"
+#include "third_party/WebKit/public/web/WebContextMenuData.h"
#include "ui/android/view_android.h"
#include "ui/android/window_android.h"
#include "ui/base/clipboard/clipboard.h"
@@ -75,6 +76,7 @@ using base::android::ConvertUTF8ToJavaString;
using base::android::JavaParamRef;
using base::android::JavaRef;
using base::android::ScopedJavaLocalRef;
+using blink::WebContextMenuData;
using blink::WebGestureEvent;
using blink::WebInputEvent;
using ui::MotionEventAndroid;
@@ -630,8 +632,11 @@ bool ContentViewCoreImpl::ShowPastePopup(const ContextMenuParams& params) {
ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
if (obj.is_null())
return false;
+ const bool can_select_all =
+ !!(params.edit_flags & WebContextMenuData::CanSelectAll);
Java_ContentViewCore_showPastePopup(env, obj, params.selection_start.x(),
- params.selection_start.y());
+ params.selection_start.y(),
+ can_select_all);
return true;
}

Powered by Google App Engine
This is Rietveld 408576698