Calculate default args for local reference completions.

Calculate default args for local reference completions.

First step towards wiring up default args for completions.

See: https://github.com/flutter/flutter-intellij/issues/553

Next up: similar enhancements for type_members, imported_refs, etc.

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/d1bfe8bccb8560a5d23a48f556ff280174bf6226

[pquitslund, 2017-03-01 18:18:25]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[scheglov, 2017-03-01 18:33:41]

lgtm

https://codereview.chromium.org/2722253002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart
(right):

https://codereview.chromium.org/2722253002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart:488:
List<String> args = requiredParams.map((p) => p.element.name).toList();
It seems inconsistently that we use elements for some things, but nodes for
another.
Maybe we should make this method to work with elements, and convert paramList to
elements before performing filterings and transformations.

https://codereview.chromium.org/2722253002/diff/1/pkg/analysis_server/test/se...
File
pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart
(right):

https://codereview.chromium.org/2722253002/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart:4627:
bool foo(int bar, {bool boo, @required int baz}) => false;
Add also test with optional positional parameters.

[Brian Wilkerson, 2017-03-01 18:37:42]

lgtm

https://codereview.chromium.org/2722253002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart
(right):

https://codereview.chromium.org/2722253002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart:475:
.where((FormalParameter param) => param is! DefaultFormalParameter);
I know you didn't write this, but it's weird that here we're using an `is` test
while below we're using an equality test on the kind. I like the code below
better, and we could change this condition to:

param.kind == ParameterKind.REQUIRED

[pquitslund, 2017-03-01 19:24:44]

Thanks!

Comments addressed.  Take another look?

https://codereview.chromium.org/2722253002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart
(right):

https://codereview.chromium.org/2722253002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart:475:
.where((FormalParameter param) => param is! DefaultFormalParameter);
On 2017/03/01 18:37:42, Brian Wilkerson wrote:
> I know you didn't write this, but it's weird that here we're using an `is`
test
> while below we're using an equality test on the kind. I like the code below
> better, and we could change this condition to:
> 
> param.kind == ParameterKind.REQUIRED

NP.  Updated!

https://codereview.chromium.org/2722253002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart:488:
List<String> args = requiredParams.map((p) => p.element.name).toList();
On 2017/03/01 18:33:41, scheglov wrote:
> It seems inconsistently that we use elements for some things, but nodes for
> another.
> Maybe we should make this method to work with elements, and convert paramList
to
> elements before performing filterings and transformations.

Works for me.

Updated.

https://codereview.chromium.org/2722253002/diff/1/pkg/analysis_server/test/se...
File
pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart
(right):

https://codereview.chromium.org/2722253002/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart:4627:
bool foo(int bar, {bool boo, @required int baz}) => false;
On 2017/03/01 18:33:41, scheglov wrote:
> Add also test with optional positional parameters.

Done.

[Brian Wilkerson, 2017-03-01 19:27:54]

lgtm

[scheglov, 2017-03-01 19:29:32]

lgtm

[pquitslund, 2017-03-01 19:45:10]

Description was changed from

==========
Calculate default args for local reference completions.

First step towards wiring up default args for completions.

See: https://github.com/flutter/flutter-intellij/issues/553

Next up: similar enhancements for type_members, imported_refs, etc.

BUG=
==========

to

==========
Calculate default args for local reference completions.

First step towards wiring up default args for completions.

See: https://github.com/flutter/flutter-intellij/issues/553

Next up: similar enhancements for type_members, imported_refs, etc.

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d1bfe8bccb8560a5d23a48f556ff280174bf6226
==========

[pquitslund, 2017-03-01 19:45:11]

Committed patchset #2 (id:20001) manually as
d1bfe8bccb8560a5d23a48f556ff280174bf6226 (presubmit successful).