Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2722223006: Move all main methods to tool/. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Updated bootstrap_test.dart. #

Patch Set 3 : Update tools/patch_sdk.dart. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -420 lines) Patch
M pkg/front_end/lib/src/fasta/analyzer/analyzer_compile.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/analyzer/compile_platform_dartk.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/front_end/lib/src/fasta/bin/compile.dart View 1 chunk +0 lines, -16 lines 0 comments Download
D pkg/front_end/lib/src/fasta/bin/compile_platform.dart View 1 chunk +0 lines, -16 lines 0 comments Download
D pkg/front_end/lib/src/fasta/bin/generate_dart_libraries.dart View 1 chunk +0 lines, -14 lines 0 comments Download
D pkg/front_end/lib/src/fasta/bin/log_analyzer.dart View 1 chunk +0 lines, -36 lines 0 comments Download
D pkg/front_end/lib/src/fasta/bin/log_collector.dart View 1 chunk +0 lines, -110 lines 0 comments Download
D pkg/front_end/lib/src/fasta/bin/outline.dart View 1 chunk +0 lines, -16 lines 0 comments Download
D pkg/front_end/lib/src/fasta/bin/run.dart View 1 chunk +0 lines, -43 lines 0 comments Download
M pkg/front_end/lib/src/fasta/compile_platform.dart View 1 chunk +16 lines, -9 lines 0 comments Download
M pkg/front_end/lib/src/fasta/outline.dart View 1 chunk +20 lines, -0 lines 0 comments Download
D pkg/front_end/lib/src/fasta/parser/bin/parser.dart View 1 chunk +0 lines, -7 lines 0 comments Download
D pkg/front_end/lib/src/fasta/parser/main.dart View 1 chunk +0 lines, -52 lines 0 comments Download
A + pkg/front_end/lib/src/fasta/parser/parser_main.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/run.dart View 2 chunks +35 lines, -1 line 0 comments Download
D pkg/front_end/lib/src/fasta/scanner/bin/scanner.dart View 1 chunk +0 lines, -7 lines 0 comments Download
D pkg/front_end/lib/src/fasta/scanner/main.dart View 1 chunk +0 lines, -34 lines 0 comments Download
A + pkg/front_end/lib/src/fasta/scanner/scanner_main.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/front_end/lib/src/fasta/scanner/testing/scanner_chain.dart View 1 chunk +0 lines, -33 lines 0 comments Download
A + pkg/front_end/lib/src/fasta/testing/scanner_chain.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/test/fasta/bootstrap_test.dart View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/front_end/test/fasta/parser/parser_suite.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/fasta/scanner/scanner_suite.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/fasta/testing.json View 1 2 1 chunk +4 lines, -5 lines 0 comments Download
M pkg/front_end/test/subpackage_relationships_test.dart View 2 chunks +1 line, -3 lines 0 comments Download
A pkg/front_end/tool/fasta/analyzer_compile.dart View 1 chunk +8 lines, -0 lines 0 comments Download
A pkg/front_end/tool/fasta/compile.dart View 1 chunk +7 lines, -0 lines 0 comments Download
A pkg/front_end/tool/fasta/compile_platform.dart View 1 chunk +7 lines, -0 lines 0 comments Download
A pkg/front_end/tool/fasta/compile_platform_dartk.dart View 1 chunk +8 lines, -0 lines 0 comments Download
A + pkg/front_end/tool/fasta/generate_dart_libraries.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/front_end/tool/fasta/log_analyzer.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/front_end/tool/fasta/log_collector.dart View 1 chunk +1 line, -1 line 0 comments Download
A pkg/front_end/tool/fasta/outline.dart View 1 chunk +7 lines, -0 lines 0 comments Download
A pkg/front_end/tool/fasta/parser.dart View 1 chunk +8 lines, -0 lines 0 comments Download
A pkg/front_end/tool/fasta/run.dart View 1 chunk +7 lines, -0 lines 0 comments Download
A pkg/front_end/tool/fasta/scanner.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M tools/patch_sdk.dart View 1 2 5 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ahe
Follow-up to CL 2726793003.
3 years, 9 months ago (2017-03-02 09:29:31 UTC) #2
Johnni Winther
lgtm
3 years, 9 months ago (2017-03-02 09:37:56 UTC) #3
ahe
3 years, 9 months ago (2017-03-02 13:41:14 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
88a92f805a7030bd563e5841fc63e70c9ef4db22 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698