Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2722203002: Use FutureOr in Completer.complete. (Closed)

Created:
3 years, 9 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 9 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Merge to head for relanding. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -12 lines) Patch
M sdk/lib/async/future.dart View 3 chunks +6 lines, -9 lines 0 comments Download
M sdk/lib/async/future_impl.dart View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Lasse Reichstein Nielsen
3 years, 9 months ago (2017-03-01 13:17:12 UTC) #2
floitsch
LGTM.
3 years, 9 months ago (2017-03-01 13:33:19 UTC) #3
Lasse Reichstein Nielsen
Committed patchset #1 (id:1) manually as a4a7d98dcea609a527fc3ed2316b68a249e9192c (presubmit successful).
3 years, 9 months ago (2017-03-01 13:36:51 UTC) #5
Lasse Reichstein Nielsen
3 years, 9 months ago (2017-03-02 09:11:13 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
00cd7580c1c8b73335acc55bfbd04459f1de42bf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698