Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2722173002: Fix bad example of URI part-of to be bad, not good. (Closed)

Created:
3 years, 9 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 9 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix bad example of URI part-of to be bad, not good. Committed: https://github.com/dart-lang/sdk/commit/e8e1857814c2c0d9ae2c5431f89a84523667259b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/compiler/lib/src/diagnostics/messages.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Lasse Reichstein Nielsen
TBR
3 years, 9 months ago (2017-03-01 12:39:58 UTC) #2
Lasse Reichstein Nielsen
Committed patchset #1 (id:1) manually as e8e1857814c2c0d9ae2c5431f89a84523667259b (presubmit successful).
3 years, 9 months ago (2017-03-01 12:40:09 UTC) #4
floitsch
3 years, 9 months ago (2017-03-01 13:04:17 UTC) #5
Message was sent while issue was closed. 
LGTM.

Powered by Google App Engine
This is Rietveld 408576698