Issue 2722133002: [Remote suggestions] Use Google server for fetching MostLikely icons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2722133002: [Remote suggestions] Use Google server for fetching MostLikely icons (Closed)

Created:
3 years, 9 months ago by jkrcal

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, sdefresne+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Remote suggestions] Use Google server for fetching MostLikely icons This CL adds support for fetching missing icons for MostLikely NTP tiles on demand from a Google favicon server. BUG=536988

Patch Set 1 #

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+108 lines, -17 lines)			Patch
M	chrome/browser/ntp_tiles/chrome_most_visited_sites_factory.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	components/ntp_tiles/icon_cacher.h	View	1 chunk	+8 lines, -2 lines	0 comments	Download
M	components/ntp_tiles/icon_cacher_impl.h	View	3 chunks	+24 lines, -6 lines	0 comments	Download
M	components/ntp_tiles/icon_cacher_impl.cc	View	5 chunks	+68 lines, -8 lines	0 comments	Download
M	components/ntp_tiles/most_visited_sites.cc	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	ios/chrome/browser/ntp_tiles/ios_most_visited_sites_factory.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 2685173002 Patch 80001