Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1849)

Unified Diff: chrome/browser/chrome_elf_init_unittest_win.cc

Issue 272213006: Switching the no-finch default behavior to enable the blacklist (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added back description of test F Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chrome_elf_init_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_elf_init_unittest_win.cc
diff --git a/chrome/browser/chrome_elf_init_unittest_win.cc b/chrome/browser/chrome_elf_init_unittest_win.cc
index b7cee8af896a99a6487b227ea91689dc24c476e9..adb2d47e2ee6b1a558f37e9c9185eb64b1ab361c 100644
--- a/chrome/browser/chrome_elf_init_unittest_win.cc
+++ b/chrome/browser/chrome_elf_init_unittest_win.cc
@@ -54,22 +54,23 @@ class ChromeBlacklistTrialTest : public testing::Test {
DISALLOW_COPY_AND_ASSIGN(ChromeBlacklistTrialTest);
};
-
-// Ensure that the default trial deletes any existing blacklist beacons.
+// Ensure that the default trial sets up the blacklist beacons.
TEST_F(ChromeBlacklistTrialTest, DefaultRun) {
// Set some dummy values as beacons.
blacklist_registry_key_->WriteValue(blacklist::kBeaconState,
blacklist::BLACKLIST_ENABLED);
csharp 2014/05/15 18:15:58 This value should be changed to disabled (so we kn
krstnmnlsn 2014/05/15 18:30:00 Done.
blacklist_registry_key_->WriteValue(blacklist::kBeaconVersion, L"Data");
- // This setup code should result in the default group, which should remove
- // all the beacon values.
+ // This setup code should result in the default group, which should have
+ // all the beacon values set.
csharp 2014/05/15 18:15:58 nit "all the beacon values set"-> "the blacklist s
krstnmnlsn 2014/05/15 18:30:00 Done.
InitializeChromeElf();
- // Ensure that invalid values are returned to indicate that the
- // beacon values are gone.
- ASSERT_EQ(blacklist::BLACKLIST_STATE_MAX, GetBlacklistState());
- ASSERT_EQ(base::string16(), GetBlacklistVersion());
+ // Ensure the beacon values are correct, indicating the
+ // blacklist beacon was setup.
+ ASSERT_EQ(blacklist::BLACKLIST_ENABLED, GetBlacklistState());
+ chrome::VersionInfo version_info;
+ base::string16 version(base::UTF8ToUTF16(version_info.Version()));
+ ASSERT_EQ(version, GetBlacklistVersion());
}
TEST_F(ChromeBlacklistTrialTest, VerifyFirstRun) {
« no previous file with comments | « no previous file | chrome/browser/chrome_elf_init_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698