Support WebIDL optional default value syntax

Source/bindings/scripts/v8_methods.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 150 matching lines @@
         'idl_type_object': idl_type,
         'index': index,
         'is_clamp': 'Clamp' in extended_attributes,
         'is_callback_interface': idl_type.is_callback_interface,
         'is_nullable': idl_type.is_nullable,
         'is_optional': argument.is_optional,
         'is_variadic_wrapper_type': is_variadic_wrapper_type,
         'vector_type': v8_types.cpp_ptr_type('Vector', 'HeapVector', idl_type.gc_type),
         'is_wrapper_type': idl_type.is_wrapper_type,
         'name': argument.name,
+        'default_value': argument.default_value,

[Nils Barth (inactive), 2014/05/16 12:22:54]

Alphabetical order please.

         'v8_set_return_value_for_main_world': v8_set_return_value(interface.name, method, this_cpp_value, for_main_world=True),
         'v8_set_return_value': v8_set_return_value(interface.name, method, this_cpp_value),
         'v8_value_to_local_cpp_value': v8_value_to_local_cpp_value(argument, index),
     }
 
 
 ################################################################################
 # Value handling
 ################################################################################
 
 def cpp_value(interface, method, number_of_arguments):
     def cpp_argument(argument):
         idl_type = argument.idl_type
         if idl_type.name == 'EventListener':
             if (interface.name == 'EventTarget' and
                 method.name == 'removeEventListener'):
                 # FIXME: remove this special case by moving get() into
                 # EventTarget::removeEventListener
                 return '%s.get()' % argument.name
             return argument.name
         if (idl_type.is_callback_interface or
             idl_type.name in ['NodeFilter', 'XPathNSResolver']):
             # FIXME: remove this special case
             return '%s.release()' % argument.name
         return argument.name
 
     # Truncate omitted optional arguments

[Nils Barth (inactive), 2014/05/16 12:22:54]

Could you move these down to the cpp_arguments.extend() lines, and omit the
auxiliary variables?
(We tend to avoid these if possible.)

-    arguments = method.arguments[:number_of_arguments]
+    required_arguments = method.arguments[:number_of_arguments]
+    optional_arguments = method.arguments[number_of_arguments:]
     cpp_arguments = v8_utilities.call_with_arguments(method)
     # Members of IDL partial interface definitions are implemented in C++ as
     # static member functions, which for instance members (non-static members)
     # take *impl as their first argument
     if ('PartialInterfaceImplementedAs' in method.extended_attributes and
         not method.is_static):
         cpp_arguments.append('*impl')
-    cpp_arguments.extend(cpp_argument(argument) for argument in arguments)
+    cpp_arguments.extend(cpp_argument(argument) for argument in required_arguments)

[Nils Barth (inactive), 2014/05/16 12:22:54]

Line breaks please, here and next line:
loop and condition both on separate lines.

+    cpp_arguments.extend(argument.default_value for argument in optional_arguments if argument.is_optional and argument.default_value)
     this_union_arguments = method.idl_type and method.idl_type.union_arguments
     if this_union_arguments:
         cpp_arguments.extend(this_union_arguments)
 
     if 'RaisesException' in method.extended_attributes:
         cpp_arguments.append('exceptionState')
 
     if method.name == 'Constructor':
         base_name = 'create'
     elif method.name == 'NamedConstructor':
@@ skipping 60 matching lines @@
 
 
 def union_arguments(idl_type):
     """Return list of ['result0Enabled', 'result0', 'result1Enabled', ...] for union types, for use in setting return value"""
     return [arg
             for i in range(len(idl_type.member_types))
             for arg in ['result%sEnabled' % i, 'result%s' % i]]
 
 IdlType.union_arguments = property(lambda self: None)
 IdlUnionType.union_arguments = property(union_arguments)