Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 272213002: Add support for 'allow-orientation-lock' sandboxing directive (Closed)

Created:
6 years, 7 months ago by Inactive
Modified:
6 years, 7 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis, Peter Beverloo
Visibility:
Public.

Description

Add support for 'allow-orientation-lock' sandboxing directive Add support for 'allow-orientation-lock' sandboxing directive when parsing sandboxing directives: https://w3c.github.io/screen-orientation/#dfn-sandboxed-orientation-lock-browsing-context-flag Also throw an SecurityError DOMException if screen.lockOrientation() is called on a Document whose active sandboxing flag set has the sandboxed orientation lock browsing context flag set, as per the latest Screen Orientation API: https://w3c.github.io/screen-orientation/#dfn-apply-an-orientation-lock R=abarth@chromium.org BUG=162827 TEST=screen_orientation/lockOrientation-sandboxed-iframe.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173806

Patch Set 1 #

Patch Set 2 : Add comment #

Patch Set 3 : Use testharness.js #

Patch Set 4 : test clean up #

Total comments: 3

Patch Set 5 : Revert bad local change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -4 lines) Patch
A LayoutTests/screen_orientation/lockOrientation-sandboxed-iframe.html View 1 2 3 1 chunk +37 lines, -0 lines 0 comments Download
A LayoutTests/screen_orientation/resources/sandboxed-iframe-locking.html View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/dom/SandboxFlags.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/SandboxFlags.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientation.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/screen_orientation/ScreenOrientation.cpp View 2 chunks +12 lines, -2 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientation.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Inactive
6 years, 7 months ago (2014-05-09 17:35:05 UTC) #1
mlamouri (slow - plz ping)
LGTM, though could you use test-harness.js instead?
6 years, 7 months ago (2014-05-09 17:42:13 UTC) #2
Inactive
On 2014/05/09 17:42:13, Mounir Lamouri wrote: > LGTM, though could you use test-harness.js instead? Is ...
6 years, 7 months ago (2014-05-09 18:01:47 UTC) #3
mlamouri (slow - plz ping)
On 2014/05/09 18:01:47, Chris Dumez wrote: > On 2014/05/09 17:42:13, Mounir Lamouri wrote: > > ...
6 years, 7 months ago (2014-05-09 18:42:31 UTC) #4
mlamouri (slow - plz ping)
On 2014/05/09 18:42:31, Mounir Lamouri wrote: > On 2014/05/09 18:01:47, Chris Dumez wrote: > > ...
6 years, 7 months ago (2014-05-09 18:44:47 UTC) #5
Inactive
On 2014/05/09 18:44:47, Mounir Lamouri wrote: > On 2014/05/09 18:42:31, Mounir Lamouri wrote: > > ...
6 years, 7 months ago (2014-05-09 20:59:23 UTC) #6
abarth-chromium
LGTM w/o the status=stable https://codereview.chromium.org/272213002/diff/50001/Source/platform/RuntimeEnabledFeatures.in File Source/platform/RuntimeEnabledFeatures.in (right): https://codereview.chromium.org/272213002/diff/50001/Source/platform/RuntimeEnabledFeatures.in#newcode105 Source/platform/RuntimeEnabledFeatures.in:105: ScreenOrientation status=stable Did you mean ...
6 years, 7 months ago (2014-05-10 00:31:59 UTC) #7
Inactive
https://codereview.chromium.org/272213002/diff/50001/Source/platform/RuntimeEnabledFeatures.in File Source/platform/RuntimeEnabledFeatures.in (right): https://codereview.chromium.org/272213002/diff/50001/Source/platform/RuntimeEnabledFeatures.in#newcode105 Source/platform/RuntimeEnabledFeatures.in:105: ScreenOrientation status=stable On 2014/05/10 00:31:59, abarth wrote: > Did ...
6 years, 7 months ago (2014-05-10 00:34:25 UTC) #8
Inactive
https://codereview.chromium.org/272213002/diff/50001/Source/platform/RuntimeEnabledFeatures.in File Source/platform/RuntimeEnabledFeatures.in (right): https://codereview.chromium.org/272213002/diff/50001/Source/platform/RuntimeEnabledFeatures.in#newcode105 Source/platform/RuntimeEnabledFeatures.in:105: ScreenOrientation status=stable On 2014/05/10 00:31:59, abarth wrote: > Did ...
6 years, 7 months ago (2014-05-10 00:36:56 UTC) #9
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 7 months ago (2014-05-10 00:42:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/272213002/70001
6 years, 7 months ago (2014-05-10 00:43:54 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 01:54:34 UTC) #12
Message was sent while issue was closed.
Change committed as 173806

Powered by Google App Engine
This is Rietveld 408576698