Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1088)

Unified Diff: chrome/browser/resources/settings/reset_page/reset_profile_dialog.js

Issue 2722083003: MD Settings: Change "view reported settings" string. (Closed)
Patch Set: Fix Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/reset_page/reset_profile_dialog.js
diff --git a/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js b/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js
index 5e89ad531d5ae8e4f2b88d9e7e87f66288436eb8..2f186273dc566c45d1d95cecb0c62e7ed3215878 100644
--- a/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js
+++ b/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js
@@ -75,6 +75,9 @@ Polymer({
this.addEventListener('cancel', function() {
this.browserProxy_.onHideResetProfileDialog();
}.bind(this));
+
+ this.$$('paper-checkbox a').addEventListener(
+ 'tap', this.onShowReportedSettingsTap_.bind(this));
Dan Beam 2017/03/01 20:29:37 is addEventListener('tap') the same as listen('tap
dpapad 2017/03/01 20:37:49 Yes, it is triggered either way. The problem I see
dpapad 2017/03/01 20:42:59 Fixed by adding a listener for keydown, see latest
},
/** @private */
@@ -123,9 +126,11 @@ Polymer({
/**
* Displays the settings that will be reported in a new tab.
+ * @param {!Event} e
* @private
*/
- onShowReportedSettingsTap_: function() {
+ onShowReportedSettingsTap_: function(e) {
this.browserProxy_.showReportedSettings();
+ e.stopPropagation();
},
});

Powered by Google App Engine
This is Rietveld 408576698