Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6824)

Unified Diff: chrome/browser/resources/settings/reset_page/reset_profile_dialog.js

Issue 2722083003: MD Settings: Change "view reported settings" string. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/reset_page/reset_profile_dialog.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/reset_page/reset_profile_dialog.js
diff --git a/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js b/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js
index 5e89ad531d5ae8e4f2b88d9e7e87f66288436eb8..4902a6d5c202e11b80a5c6159084e8154e86ee62 100644
--- a/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js
+++ b/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js
@@ -123,9 +123,11 @@ Polymer({
/**
* Displays the settings that will be reported in a new tab.
+ * @param {!Event} e
* @private
*/
- onShowReportedSettingsTap_: function() {
- this.browserProxy_.showReportedSettings();
+ onShowReportedSettingsTap_: function(e) {
+ if (Polymer.dom(e).localTarget.tagName == 'A')
Dan Beam 2017/03/01 19:10:03 did you try else e.stopPropagation(); or preve
dpapad 2017/03/01 19:30:11 Yes. Tried both and did not fix the issue. The che
dpapad 2017/03/01 19:31:10 Correction: I don't have an *declarative* way of a
Dan Beam 2017/03/01 19:44:45 did you try stopImmediatePropagation()?
dpapad 2017/03/01 20:05:03 I figured out a way to fix (see latest patch). Th
+ this.browserProxy_.showReportedSettings();
},
});
« no previous file with comments | « chrome/browser/resources/settings/reset_page/reset_profile_dialog.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698