Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2015 The Chromium Authors. All rights reserved. | 1 // Copyright 2015 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 /** | 5 /** |
| 6 * @fileoverview | 6 * @fileoverview |
| 7 * | 7 * |
| 8 * 'settings-reset-profile-dialog' is the dialog shown for clearing profile | 8 * 'settings-reset-profile-dialog' is the dialog shown for clearing profile |
| 9 * settings. A triggered variant of this dialog can be shown under certain | 9 * settings. A triggered variant of this dialog can be shown under certain |
| 10 * circumstances. See triggered_profile_resetter.h for when the triggered | 10 * circumstances. See triggered_profile_resetter.h for when the triggered |
| (...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 116 this.$.sendSettings.checked, this.resetRequestOrigin_).then(function() { | 116 this.$.sendSettings.checked, this.resetRequestOrigin_).then(function() { |
| 117 this.clearingInProgress_ = false; | 117 this.clearingInProgress_ = false; |
| 118 if (this.$.dialog.open) | 118 if (this.$.dialog.open) |
| 119 this.$.dialog.close(); | 119 this.$.dialog.close(); |
| 120 this.fire('reset-done'); | 120 this.fire('reset-done'); |
| 121 }.bind(this)); | 121 }.bind(this)); |
| 122 }, | 122 }, |
| 123 | 123 |
| 124 /** | 124 /** |
| 125 * Displays the settings that will be reported in a new tab. | 125 * Displays the settings that will be reported in a new tab. |
| 126 * @param {!Event} e | |
| 126 * @private | 127 * @private |
| 127 */ | 128 */ |
| 128 onShowReportedSettingsTap_: function() { | 129 onShowReportedSettingsTap_: function(e) { |
| 129 this.browserProxy_.showReportedSettings(); | 130 if (Polymer.dom(e).localTarget.tagName == 'A') |
|
Dan Beam
2017/03/01 19:10:03
did you try
else
e.stopPropagation();
or preve
dpapad
2017/03/01 19:30:11
Yes. Tried both and did not fix the issue. The che
dpapad
2017/03/01 19:31:10
Correction: I don't have an *declarative* way of a
Dan Beam
2017/03/01 19:44:45
did you try stopImmediatePropagation()?
dpapad
2017/03/01 20:05:03
I figured out a way to fix (see latest patch).
Th
| |
| 131 this.browserProxy_.showReportedSettings(); | |
| 130 }, | 132 }, |
| 131 }); | 133 }); |
| OLD | NEW |