Issue 2722033002: Add an AST factory method for fieldDeclaration with all optional named parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2722033002: Add an AST factory method for fieldDeclaration with all optional named parameters. (Closed)

Created:
3 years, 9 months ago by Paul Berry

Modified:
3 years, 9 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Add an AST factory method for fieldDeclaration with all optional named parameters. Also add 'covariantKeyword' to the Impl constructors and named factories. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/79cce42e38acbf08d97616fccf966029b7624c50

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+71 lines, -37 lines)			Patch
M	pkg/analyzer/lib/dart/ast/ast.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/dart/ast/ast_factory.dart	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/dart/ast/ast.dart	View	2 chunks	+8 lines, -2 lines	0 comments	Download
M	pkg/analyzer/lib/src/dart/ast/ast_factory.dart	View	1 chunk	+12 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/dart/ast/utilities.dart	View	2 chunks	+14 lines, -12 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/parser.dart	View	2 chunks	+13 lines, -16 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/testing/ast_test_factory.dart	View	1 chunk	+5 lines, -6 lines	0 comments	Download

Total messages: 5 (2 generated)

Paul Berry

3 years, 9 months ago (2017-03-01 00:43:37 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
79cce42e38acbf08d97616fccf966029b7624c50 (presubmit successful).