Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 272203002: Reland and fix r21225 and r21226 (Closed)

Created:
6 years, 7 months ago by Toon Verwaest
Modified:
6 years, 7 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Visibility:
Public.

Description

Reland and fix r21225 and r21226 BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21232

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -57 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/objects.h View 4 chunks +19 lines, -20 lines 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects-inl.h View 2 chunks +7 lines, -8 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 7 months ago (2014-05-09 16:12:28 UTC) #1
Igor Sheludko
lgtm
6 years, 7 months ago (2014-05-09 16:18:22 UTC) #2
Toon Verwaest
6 years, 7 months ago (2014-05-09 16:19:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21232 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698