Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2721953004: Unset GREP_OPTIONS when extracting processor count (Closed)

Created:
3 years, 9 months ago by Chris Bracken
Modified:
3 years, 9 months ago
Reviewers:
Cutch, rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Unset GREP_OPTIONS when extracting processor count If GREP_OPTIONS includes -n or --line-number, matches will be emitted with a line number following the filename. Unset GREP_OPTIONS to ensure we're getting expected output. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/c9442bb8a2fa893c3178dcab7635abcb4b5f9310

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/tools/utils.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Chris Bracken
3 years, 9 months ago (2017-02-28 23:51:08 UTC) #2
Cutch
lgtm
3 years, 9 months ago (2017-02-28 23:57:54 UTC) #3
Chris Bracken
3 years, 9 months ago (2017-03-01 00:00:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c9442bb8a2fa893c3178dcab7635abcb4b5f9310 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698