[Media Router] Add "Hide in menu/Show in toolbar" option to Cast toolbar icon

chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/extensions/browser_action_test_util.h"
 #include "chrome/browser/media/router/media_router_ui_service.h"
 #include "chrome/browser/renderer_context_menu/render_view_context_menu_test_util.h"
@@ skipping 71 matching lines @@
         nav_observer.last_navigation_url().spec());
     nav_observer.StopWatchingNewWebContents();
   }
 
   MediaRouterAction* GetMediaRouterAction() {
     return MediaRouterDialogControllerImpl::GetOrCreateForWebContents(
                browser()->tab_strip_model()->GetActiveWebContents())
         ->action();
   }
 
+  ui::SimpleMenuModel* GetActionContextMenu() {
+    return static_cast<ui::SimpleMenuModel*>(
+        GetMediaRouterAction()->GetContextMenu());
+  }
+
   void ExecuteMediaRouterAction(AppMenuButton* app_menu_button) {
     EXPECT_TRUE(app_menu_button->IsMenuShowing());
     GetMediaRouterAction()->ExecuteAction(true);
   }
 
   bool ActionExists() {
     return ToolbarActionsModel::Get(browser()->profile())
         ->HasComponentAction(
             ComponentToolbarActionsFactory::kMediaRouterActionId);
   }
@@ skipping 215 matching lines @@
   EXPECT_TRUE(ActionExists());
   action_controller_->OnRoutesUpdated(std::vector<MediaRoute>(),
                                       std::vector<MediaRoute::Id>());
   EXPECT_FALSE(ActionExists());
   action_controller_->OnRoutesUpdated(routes_, std::vector<MediaRoute::Id>());
   EXPECT_TRUE(ActionExists());
   browser2->window()->Close();
   EXPECT_TRUE(ActionExists());
 }
 
+IN_PROC_BROWSER_TEST_F(MediaRouterUIBrowserTest, HideActionInOverflow) {

[apacible, 2017/03/02 02:02:57]

nit: s/HideActionInOverflow/UpdateActionLocation ? since this test moves the
icon between the toolbar and overflow.

[takumif, 2017/03/03 00:10:48]

Done.

+  SetAlwaysShowActionPref(true);
+
+  // Get the index for "Hide in Chrome menu" / "Show in toolbar" menu item.
+  const int command_index = GetActionContextMenu()->GetIndexOfCommandId(
+      IDC_MEDIA_ROUTER_SHOW_IN_TOOLBAR);
+
+  // Start out with the action visible on the main bar.
+  EXPECT_TRUE(
+      toolbar_actions_bar_->IsActionVisibleOnMainBar(GetMediaRouterAction()));
+  GetActionContextMenu()->ActivatedAt(command_index);
+
+  // The action should get hidden in the overflow menu.
+  EXPECT_FALSE(
+      toolbar_actions_bar_->IsActionVisibleOnMainBar(GetMediaRouterAction()));
+  GetActionContextMenu()->ActivatedAt(command_index);
+
+  // The action should be back on the main bar.
+  EXPECT_TRUE(
+      toolbar_actions_bar_->IsActionVisibleOnMainBar(GetMediaRouterAction()));
+}
+
 }  // namespace media_router