net/http/http_transaction.h - Issue 2721933002: HttpCache::Transaction layer allowing parallel validation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_transaction.h

Issue 2721933002: HttpCache::Transaction layer allowing parallel validation (Closed)

Patch Set: Fixing resetting the cache_entry_status_. Should fix the webkit_tests failing in linux_trusty_blink… Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_transaction.h

diff --git a/net/http/http_transaction.h b/net/http/http_transaction.h

index eff45d10c5648d618e4366a6ea91a398b06016b1..014fa72c60684c1c3757dee835be46eb3c9dc60b 100644

--- a/net/http/http_transaction.h

+++ b/net/http/http_transaction.h

@@ -54,7 +54,9 @@ class NET_EXPORT_PRIVATE HttpTransaction {

// The consumer should ensure that request_info points to a valid value till

// final response headers are received; after that point, the HttpTransaction

- // will not access |*request_info| and it may be deleted.

+ // will not access |*request_info| and it may be deleted. Note that in case of

+ // range requests response headers may be received multiple times and the

+ // HttpTransaction might access |*request_info| in all of those.

// Returns OK if the transaction could be started synchronously, which means

// that the request was served from the cache. ERR_IO_PENDING is returned to