Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: net/http/mock_http_cache.h

Issue 2721933002: HttpCache::Transaction layer allowing parallel validation (Closed)
Patch Set: Fixed data race Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/mock_http_cache.h
diff --git a/net/http/mock_http_cache.h b/net/http/mock_http_cache.h
index a24200bf8348cd2ea0ed018a54c7832386195bad..7718f35116974bb17bda26854341e77f7b93ba5f 100644
--- a/net/http/mock_http_cache.h
+++ b/net/http/mock_http_cache.h
@@ -158,6 +158,8 @@ class MockDiskCache : public disk_cache::Backend {
void ReleaseAll();
+ bool IsDiskEntryDoomed(const std::string& key);
+
private:
using EntryMap = std::unordered_map<std::string, MockDiskEntry*>;
class NotImplementedIterator;
@@ -234,6 +236,14 @@ class MockHttpCache {
// the test! (by setting test_mode to zero).
static void SetTestMode(int test_mode);
+ // Functions to test the state of ActiveEntry.
+
+ bool IsWriterPresent(const std::string& key);
+ bool IsHeadersTransactionPresent(const std::string& key);
+ int GetCountReaders(const std::string& key);
+ int GetCountAddToEntryQueue(const std::string& key);
+ int GetCountDoneHeadersQueue(const std::string& key);
+
private:
HttpCache http_cache_;
};

Powered by Google App Engine
This is Rietveld 408576698