Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: net/url_request/url_request_unittest.cc

Issue 2721933002: HttpCache::Transaction layer allowing parallel validation (Closed)
Patch Set: Truncation and StopCaching changes. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/http/mock_http_cache.h ('K') | « net/url_request/url_request_quic_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_unittest.cc
diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc
index 2d158a0492764e8196d54bd59c0bd6f0be81e459..7534e01544c828c6d58f621fdd8133ccacbf8205 100644
--- a/net/url_request/url_request_unittest.cc
+++ b/net/url_request/url_request_unittest.cc
@@ -4191,14 +4191,14 @@ TEST_F(URLRequestTestHTTP,
url, DEFAULT_PRIORITY, &d, TRAFFIC_ANNOTATION_FOR_TESTS));
r->Start();
+ base::RunLoop().Run();
jkarlin 2017/06/08 16:14:10 Why the change to this file?
shivanisha 2017/06/08 18:26:02 Because of addition of the transaction to add_to_e
+
{
HttpRequestHeaders headers;
EXPECT_TRUE(r->GetFullRequestHeaders(&headers));
- EXPECT_FALSE(headers.HasHeader("Authorization"));
+ EXPECT_TRUE(headers.HasHeader("Authorization"));
}
- base::RunLoop().Run();
-
EXPECT_EQ(OK, d.request_status());
EXPECT_EQ(200, r->GetResponseCode());
EXPECT_TRUE(d.auth_required_called());
« net/http/mock_http_cache.h ('K') | « net/url_request/url_request_quic_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698