tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 6c89c0a9380ff3b2fc00705b4a0a6b48ca42e2df..eb27592907043492a514eea6fbc9e3a052721880 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -2998,6 +2998,139 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="AuthPolicy.ErrorTypeOfAuthenticateUser"
+    enum="AuthPolicyErrorType">
+  <owner>ljusten@chromium.org</owner>
+  <summary>
+    Result from an attempt to authenticate a user to an Active Directory domain.
+  </summary>
+</histogram>
+
+<histogram name="AuthPolicy.ErrorTypeOfJoinADDomain" enum="AuthPolicyErrorType">
+  <owner>ljusten@chromium.org</owner>
+  <summary>
+    Result from an attempt to join a machine to an Active Directory domain.
+  </summary>
+</histogram>
+
+<histogram name="AuthPolicy.ErrorTypeOfRefreshDevicePolicy"
+    enum="AuthPolicyErrorType">
+  <owner>ljusten@chromium.org</owner>
+  <summary>
+    Result from an attempt to fetch device policy from an Active Directory
+    domain and store it on disk.
+  </summary>
+</histogram>
+
+<histogram name="AuthPolicy.ErrorTypeOfRefreshUserPolicy"
+    enum="AuthPolicyErrorType">
+  <owner>ljusten@chromium.org</owner>
+  <summary>
+    Result from an attempt to fetch user policy from an Active Directory domain
+    and store it on disk.
+  </summary>
+</histogram>
+
+<histogram name="AuthPolicy.NumGposToDownload">
+  <owner>ljusten@chromium.org</owner>
+  <summary>
+    Number of group policy objects attached to a specific user or machine on an
+    Active Directory domain.

[Mark P, 2017/03/01 04:52:28]

Please state when this is recorded.
https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histo...

[ljusten (tachyonic), 2017/03/01 10:16:22]

Done.

+  </summary>
+</histogram>
+
+<histogram name="AuthPolicy.TimeToAuthenticateUser">

[Mark P, 2017/03/01 04:52:28]

units="ms"
ditto on almost every histogram below

[ljusten (tachyonic), 2017/03/01 10:16:22]

Done.

+  <owner>ljusten@chromium.org</owner>
+  <summary>
+    Time in milliseconds to authenticate a user to an Active Directory domain.

[Mark P, 2017/03/01 04:52:28]

Recorded always or only on success?  Please make the description clear.

ditto on almost every histogram below.

[ljusten (tachyonic), 2017/03/01 10:16:22]

Done.

+  </summary>
+</histogram>
+
+<histogram name="AuthPolicy.TimeToJoinADDomain">
+  <owner>ljusten@chromium.org</owner>
+  <summary>
+    Time in milliseconds to join a machine to an Active Directory domain.
+  </summary>
+</histogram>
+
+<histogram name="AuthPolicy.TimeToRefreshDevicePolicy">
+  <owner>ljusten@chromium.org</owner>
+  <summary>
+    Time in milliseconds to fetch device policy from an Active Directory domain
+    and store it on disk.
+  </summary>
+</histogram>
+
+<histogram name="AuthPolicy.TimeToRefreshUserPolicy">
+  <owner>ljusten@chromium.org</owner>
+  <summary>
+    Time in milliseconds to fetch user policy from an Active Directory domain
+    and store it on disk.
+  </summary>
+</histogram>
+
+<histogram name="AuthPolicy.TimeToRunKinit">
+  <owner>ljusten@chromium.org</owner>
+  <summary>
+    Time in milliseconds to call 'kinit' (request Kerberos
+    ticket-granting-ticket).
+  </summary>
+</histogram>
+
+<histogram name="AuthPolicy.TimeToRunNetAdsInfo">
+  <owner>ljusten@chromium.org</owner>
+  <summary>
+    Time in milliseconds to call 'net ads info' (query Active Directory
+    information).
+  </summary>
+</histogram>
+
+<histogram name="AuthPolicy.TimeToRunNetAdsJoin">
+  <owner>ljusten@chromium.org</owner>
+  <summary>
+    Time in milliseconds to call 'net ads join' (join machine to an Active
+    Directory domain).
+  </summary>
+</histogram>
+
+<histogram name="AuthPolicy.TimeToRunNetAdsSearch">
+  <owner>ljusten@chromium.org</owner>
+  <summary>
+    Time in milliseconds to call 'net ads search' (query information about an
+    Active Directory account).
+  </summary>
+</histogram>
+
+<histogram name="AuthPolicy.TimeToRunNetAdsWorkgroup">
+  <owner>ljusten@chromium.org</owner>
+  <summary>
+    Time in milliseconds to call 'net ads workgroup' (query Active Directory
+    workgroup).
+  </summary>
+</histogram>
+
+<histogram name="AuthPolicy.TimeToRunSmbclient">
+  <owner>ljusten@chromium.org</owner>
+  <summary>
+    Time in milliseconds to call 'smbclient' (download policy from an Active
+    Directory domain).
+  </summary>
+</histogram>
+
+<histogram name="AuthPolicy.TriesOfKinit">
+  <owner>ljusten@chromium.org</owner>
+  <summary>
+    Number of times 'kinit' was tried until it succeeded or gave up.

[Mark P, 2017/03/01 04:52:28]

What's the give-up criteria?  A fixed number of failures?  A certain amount of
time?  etc.  Depending on this, it might be really hard to interpret this
histogram without breaking it up by successes versus failures.

ditto below

[ljusten (tachyonic), 2017/03/01 10:16:22]

Max number of tries. I have a question about this. Say the max number of tries
is 10. It would be nice to distinguish 9 failures + 1 success from 10 failures,
but both are technically 10 tries. I suggested to record 10 failures as 11 tries
and catch 11 in the overflow bucket, so that it's very clear from the histograms
that it actually gave up. However, my reviewers didn't like that since it's not
11 tries.

How do others handle this? Maybe I should record failures instead of tries?

+  </summary>
+</histogram>
+
+<histogram name="AuthPolicy.TriesOfSmbClient">
+  <owner>ljusten@chromium.org</owner>
+  <summary>
+    Number of times 'smbclient' was tried until it succeeded or gave up.
+  </summary>
+</histogram>
+
 <histogram name="Autocheckout.Bubble" enum="AutocheckoutBubble">
   <obsolete>
     Deprecated as of 8/2013.
@@ -80267,6 +80400,35 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   <int value="2" label="Processing in WebRTC"/>
 </enum>
 
+<enum name="AuthPolicyErrorType" type="int">
+  <int value="0" label="Success"/>
+  <int value="1" label="Unspecified error"/>
+  <int value="2" label="Unspecified D-Bus error"/>
+  <int value="3" label="Badly formatted user principal name"/>
+  <int value="4" label="Auth failed because of bad user name"/>
+  <int value="5" label="Auth failed because of bad password"/>
+  <int value="6" label="Auth failed because of expired password"/>
+  <int value="7" label="Auth failed because of bad realm or network"/>
+  <int value="8" label="kinit exited with unspecified error"/>
+  <int value="9" label="net exited with unspecified error"/>
+  <int value="10" label="smdclient exited with unspecified error"/>
+  <int value="11" label="authpolicy_parser exited with unknown error"/>
+  <int value="12" label="Parsing GPOs failed"/>
+  <int value="13" label="GPO data is bad"/>
+  <int value="14" label="Some local IO operation failed"/>
+  <int value="15" label="Machine is not joined to AD domain yet"/>
+  <int value="16" label="User is not logged in yet"/>
+  <int value="17" label="Failed to send policy to Session Manager"/>
+  <int value="18"
+      label="User doesn't have the right to join machines to the domain"/>
+  <int value="19" label="General network problem"/>
+  <int value="20" label="Machine name contains restricted characters"/>
+  <int value="21" label="Machine name too long"/>
+  <int value="22" label="User joined maximum number of machines to the domain"/>
+  <int value="23"
+      label="kinit or smbclient failed to contact Key Distribution Center"/>
+</enum>
+
 <enum name="AutocheckoutBubble" type="int">
   <obsolete>
     Deprecated as of 8/2013.