content/browser/service_worker/embedded_worker_test_helper.cc - Issue 272183005: Stop ServiceWorker context when no controllee is associated (and when all refs are dropped)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/embedded_worker_test_helper.cc

Issue 272183005: Stop ServiceWorker context when no controllee is associated (and when all refs are dropped) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: addressed comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/embedded_worker_instance.cc ('k') | content/browser/service_worker/service_worker_context_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/embedded_worker_test_helper.cc

diff --git a/content/browser/service_worker/embedded_worker_test_helper.cc b/content/browser/service_worker/embedded_worker_test_helper.cc

index 3d8790f6a531d159e08bbc6a6e1702fb6587a9d0..c43808b28b5da72a8b71fd5439ee04d544623a99 100644

--- a/content/browser/service_worker/embedded_worker_test_helper.cc

+++ b/content/browser/service_worker/embedded_worker_test_helper.cc

@@ -154,8 +154,8 @@ void EmbeddedWorkerTestHelper::SimulateWorkerStarted(

void EmbeddedWorkerTestHelper::SimulateWorkerStopped(

int embedded_worker_id) {

EmbeddedWorkerInstance* worker = registry()->GetWorker(embedded_worker_id);

- ASSERT_TRUE(worker != NULL);

- registry()->OnWorkerStopped(worker->process_id(), embedded_worker_id);

+ if (worker != NULL)

+ registry()->OnWorkerStopped(worker->process_id(), embedded_worker_id);

}

void EmbeddedWorkerTestHelper::SimulateSend(