Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Issue 272183003: ARM64: Small optimisations (Closed)

Created:
6 years, 7 months ago by m.m.capewell
Modified:
6 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

A number of small changes: - Change ConstantD for +/-zero constants to use the fp_zero register. - Use Bfi in DoConstructDouble. - Use Tbz for positive dividend check in mod by constant. - Optimize some deoptimize checks. - Fix a couple of style/consistency issues. BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21311

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -25 lines) Patch
M src/arm64/lithium-arm64.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 8 chunks +25 lines, -18 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
m.m.capewell
6 years, 7 months ago (2014-05-13 17:03:28 UTC) #1
ulan
lgtm
6 years, 7 months ago (2014-05-14 07:39:38 UTC) #2
ulan
lgtm lgtm
6 years, 7 months ago (2014-05-14 07:39:38 UTC) #3
ulan
On 2014/05/14 07:39:38, ulan wrote: > lgtm > > lgtm I apparently did double-click in ...
6 years, 7 months ago (2014-05-14 07:42:37 UTC) #4
m.m.capewell
6 years, 7 months ago (2014-05-14 14:01:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r21311 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698