Make SelectionPopupController.ShowPastePopup only be triggered by Blink

content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser;
 
 import android.annotation.TargetApi;
 import android.app.Activity;
 import android.app.SearchManager;
 import android.content.ClipboardManager;
@@ skipping 205 matching lines @@
         return isActionModeValid();
     }
 
     @TargetApi(Build.VERSION_CODES.M)
     private ActionMode startFloatingActionMode() {
         ActionMode actionMode = mView.startActionMode(
                 new FloatingActionModeCallback(this, mCallback), ActionMode.TYPE_FLOATING);
         return actionMode;
     }
 
-    void showPastePopup(int x, int y) {
+    void createAndShowPastePopup(int x, int y) {
         if (mView.getParent() == null || mView.getVisibility() != View.VISIBLE) {
             return;
         }
 
         if (!supportsFloatingActionMode() && !canPaste()) return;
+        PastePopupMenuDelegate delegate = new PastePopupMenuDelegate() {

[boliu, 2017/03/17 22:54:20]

does it matter if mPastePopupMenu already exists here? or should that never
happen, so maybe there should be an assert here?

[amaralp, 2017/03/21 00:26:24]

Addressed in crrev.com/2757313003.

+            @Override
+            public void paste() {
+                mWebContents.paste();
+                mWebContents.dismissTextHandles();
+            }
 
-        PastePopupMenu pastePopupMenu = getPastePopup();
-        if (pastePopupMenu == null) return;
+            @Override
+            public boolean canPaste() {
+                return SelectionPopupController.this.canPaste();
+            }
+        };
+        Context windowContext = mWindowAndroid.getContext().get();
+        if (windowContext == null) return;
+        if (supportsFloatingActionMode()) {
+            mPastePopupMenu = new FloatingPastePopupMenu(windowContext, mView, delegate);
+        } else {
+            mPastePopupMenu = new LegacyPastePopupMenu(windowContext, mView, delegate);
+        }
+        showPastePopup(x, y);
+    }
 
+    private void showPastePopup(int x, int y) {
+        if (mPastePopupMenu == null) return;
         // Coordinates are in DIP.
         final float deviceScale = mRenderCoordinates.getDeviceScaleFactor();
         final int xPix = (int) (x * deviceScale);
         final int yPix = (int) (y * deviceScale);
         final float browserControlsShownPix = mRenderCoordinates.getContentOffsetYPix();
         try {
-            pastePopupMenu.show(xPix, (int) (yPix + browserControlsShownPix));
+            mPastePopupMenu.show(xPix, (int) (yPix + browserControlsShownPix));
         } catch (WindowManager.BadTokenException e) {
         }
     }
 
     @Override
     public boolean supportsFloatingActionMode() {
         return Build.VERSION.SDK_INT >= Build.VERSION_CODES.M;
     }
 
     void hidePastePopup() {
         if (mPastePopupMenu != null) mPastePopupMenu.hide();
     }
 
-    private PastePopupMenu getPastePopup() {
-        if (mPastePopupMenu == null) {
-            PastePopupMenuDelegate delegate = new PastePopupMenuDelegate() {
-                @Override
-                public void paste() {
-                    mWebContents.paste();
-                    mWebContents.dismissTextHandles();
-                }
-
-                @Override
-                public boolean canPaste() {
-                    return SelectionPopupController.this.canPaste();
-                }
-            };
-            Context windowContext = mWindowAndroid.getContext().get();
-            if (windowContext == null) return null;
-            if (supportsFloatingActionMode()) {
-                mPastePopupMenu = new FloatingPastePopupMenu(windowContext, mView, delegate);
-            } else {
-                mPastePopupMenu = new LegacyPastePopupMenu(windowContext, mView, delegate);
-            }
-        }
-        return mPastePopupMenu;
-    }
-
     void destroyPastePopup() {
         hidePastePopup();
         mPastePopupMenu = null;
     }
 
     @VisibleForTesting
     public boolean isPastePopupShowing() {
         return mPastePopupMenu != null && mPastePopupMenu.isShowing();
     }
 
@@ skipping 500 matching lines @@
                 break;
 
             case SelectionEventType.INSERTION_HANDLE_SHOWN:
                 mSelectionRect.set(left, top, right, bottom);
                 setIsInsertion(true);
                 break;
 
             case SelectionEventType.INSERTION_HANDLE_MOVED:
                 mSelectionRect.set(left, top, right, bottom);
                 if (!isScrollInProgress && isPastePopupShowing()) {
-                    mWebContents.showContextMenuAtPoint(xAnchor, yAnchor);
+                    showPastePopup(xAnchor, yAnchor);
                 } else {
                     hidePastePopup();
                 }
                 break;
 
             case SelectionEventType.INSERTION_HANDLE_TAPPED:
                 if (mWasPastePopupShowingOnInsertionDragStart) {
                     hidePastePopup();
                 } else {
                     mWebContents.showContextMenuAtPoint(xAnchor, yAnchor);
@@ skipping 98 matching lines @@
         mIsInsertion = insertion;
     }
 
     private boolean isShareAvailable() {
         Intent intent = new Intent(Intent.ACTION_SEND);
         intent.setType("text/plain");
         return mContext.getPackageManager().queryIntentActivities(intent,
                 PackageManager.MATCH_DEFAULT_ONLY).size() > 0;
     }
 }