Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 27218003: Use as/cc/ld flags in all situations (Closed)

Created:
7 years, 2 months ago by khim
Modified:
7 years, 2 months ago
Reviewers:
halayvin, halyavin
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Use as/cc/ld flags in all situations Mostly cosmetic change but also fixes one unusual case: build of x86-64 NaCl with i386 toolchain. TEST=trybots (+look on trybot logs) R=halyavin@google.com Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=12255

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M site_scons/site_tools/naclsdk.py View 3 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
khim
7 years, 2 months ago (2013-10-15 12:58:23 UTC) #1
halyavin
lgtm
7 years, 2 months ago (2013-10-15 13:19:57 UTC) #2
khim
7 years, 2 months ago (2013-10-15 13:49:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r12255 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698