Issue 27218: Enable new tab page for Mac and Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27218: Enable new tab page for Mac and Linux (Closed)

Created:
11 years, 10 months ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
TVL

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Enable new tab page for Mac and Linux

Patch Set 1 #

Total comments: 1

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -6 lines)			Patch
M	chrome/browser/dom_ui/dom_ui_contents.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/dom_ui/new_tab_ui.cc	View	1 chunk	+4 lines, -0 lines	1 comment	Download
M	chrome/browser/tab_contents/tab_contents_factory.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/common/temp_scaffolding_stubs.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

TVL

11 years, 10 months ago (2009-02-26 18:07:21 UTC) #2

lgtm

http://codereview.chromium.org/27218/diff/1/3
File chrome/browser/dom_ui/new_tab_ui.cc (right):

http://codereview.chromium.org/27218/diff/1/3#newcode192
Line 192: #endif
nit- #else NOTIMPL?

Expand Messages | Collapse Messages