Fix legacy dummy window visibility inheritance. RenderWidgetHostViewAura may be shown(::Show()) bef…

Fix legacy dummy window visibility inheritance. RenderWidgetHostViewAura may be shown(::Show()) before legacy window creation, in such case dummy window was later created hidden which leads to wrong behaviour. E.g. NPAPI Flash in windowless mode tracks associated window visibility and slows down draw invalidation.

R=ben@chromium.org
BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270739

[Ben Goodger (Google), 2014-05-13 20:54:52]

https://codereview.chromium.org/272173002/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/render_widget_host_view_aura.cc (right):

https://codereview.chromium.org/272173002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/render_widget_host_view_aura.cc:1007:
legacy_render_widget_host_HWND_->Show();
nit: no braces and 2-space indent only.

[ajax16384, 2014-05-13 21:12:52]

On 2014/05/13 20:54:52, Ben Goodger (Google) wrote:
>
https://codereview.chromium.org/272173002/diff/1/content/browser/renderer_hos...
> File content/browser/renderer_host/render_widget_host_view_aura.cc (right):
> 
>
https://codereview.chromium.org/272173002/diff/1/content/browser/renderer_hos...
> content/browser/renderer_host/render_widget_host_view_aura.cc:1007:
> legacy_render_widget_host_HWND_->Show();
> nit: no braces and 2-space indent only.

fixed

[Ben Goodger (Google), 2014-05-14 22:36:12]

lgtm

[ajax16384, 2014-05-15 09:30:46]

The CQ bit was checked by ajax16384@gmail.com

[commit-bot: I haz the power, 2014-05-15 09:31:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ajax16384@gmail.com/272173002/20001

[commit-bot: I haz the power, 2014-05-15 13:20:01]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-15 13:23:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-15 13:23:25]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[ajax16384, 2014-05-15 13:54:27]

The CQ bit was checked by ajax16384@gmail.com

[commit-bot: I haz the power, 2014-05-15 13:54:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ajax16384@gmail.com/272173002/20001

[ajax16384, 2014-05-15 14:02:11]

The CQ bit was checked by ajax16384@gmail.com

[commit-bot: I haz the power, 2014-05-15 14:03:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ajax16384@gmail.com/272173002/40001

[commit-bot: I haz the power, 2014-05-15 16:01:42]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)

[commit-bot: I haz the power, 2014-05-15 18:16:59]

Change committed as 270739

[ajax16384, 2014-05-22 10:43:13]

A revert of this CL has been created in
https://codereview.chromium.org/292203008/ by ajax16384@gmail.com.

The reason for reverting is: regression:
https://code.google.com/p/chromium/issues/detail?id=375685


.

[tapted, 2014-06-02 01:09:59]

A revert of this CL has been created in
https://codereview.chromium.org/309553010/ by tapted@chromium.org.

The reason for reverting is: Regression: makes frameless packaged app windows
unmovable in Aero. Confirmed with local git revert.

BUG=374681
.