Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: components/history/core/browser/typed_url_sync_metadata_database_unittest.cc

Issue 2721713002: [sync] Add typed url sync metadata to the history db (Closed)
Patch Set: Pavely review Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/history/core/browser/typed_url_sync_metadata_database_unittest.cc
diff --git a/components/history/core/browser/typed_url_sync_metadata_database_unittest.cc b/components/history/core/browser/typed_url_sync_metadata_database_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..1cbf32ff4a38cf7d17dc0c95ffb3693eaf88658d
--- /dev/null
+++ b/components/history/core/browser/typed_url_sync_metadata_database_unittest.cc
@@ -0,0 +1,142 @@
+// Copyright (c) 2017 The Chromium Authors. All rights reserved.
sky 2017/03/01 04:15:24 no (c) (see style guide)
Gang Wu 2017/03/02 05:41:12 Done.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/history/core/browser/typed_url_sync_metadata_database.h"
+
+#include "base/files/file_path.h"
+#include "base/files/scoped_temp_dir.h"
+#include "components/sync/protocol/model_type_state.pb.h"
+#include "sql/statement.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using sync_pb::EntityMetadata;
+using sync_pb::ModelTypeState;
+using syncer::EntityMetadataMap;
+using syncer::MetadataBatch;
+
+namespace history {
+
+class TypedURLSyncMetadataDatabaseTest : public testing::Test,
+ public TypedURLSyncMetadataDatabase {
+ public:
+ TypedURLSyncMetadataDatabaseTest() {}
+ ~TypedURLSyncMetadataDatabaseTest() override {}
+
+ protected:
+ sql::Connection& GetDB() override { return db_; }
+
+ void SetUp() override {
+ ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
+ base::FilePath db_file =
+ temp_dir_.GetPath().AppendASCII("TypedURLSyncMetadataDatabaseTest.db");
+
+ EXPECT_TRUE(db_.Open(db_file));
+
+ // Initialize the tables for this test.
+ InitSyncTable();
+ }
+ void TearDown() override { db_.Close(); }
+
+ base::ScopedTempDir temp_dir_;
+ sql::Connection db_;
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(TypedURLSyncMetadataDatabaseTest);
+};
+
+TEST_F(TypedURLSyncMetadataDatabaseTest, TypedURLNoMetadata) {
+ MetadataBatch metadata_batch;
+ EXPECT_TRUE(GetAllSyncMetadata(syncer::TYPED_URLS, &metadata_batch));
+ EXPECT_EQ(0u, metadata_batch.TakeAllMetadata().size());
+ EXPECT_EQ(ModelTypeState().SerializeAsString(),
+ metadata_batch.GetModelTypeState().SerializeAsString());
+}
+
+TEST_F(TypedURLSyncMetadataDatabaseTest, TypedURLGetAllSyncMetadata) {
+ EntityMetadata metadata;
+ std::string storage_key = "storage_key";
+ std::string storage_key2 = "storage_key2";
+ metadata.set_sequence_number(1);
+
+ EXPECT_TRUE(UpdateSyncMetadata(syncer::TYPED_URLS, storage_key, metadata));
+
+ ModelTypeState model_type_state;
+ model_type_state.set_initial_sync_done(true);
+
+ EXPECT_TRUE(UpdateModelTypeState(syncer::TYPED_URLS, model_type_state));
+
+ metadata.set_sequence_number(2);
+ EXPECT_TRUE(UpdateSyncMetadata(syncer::TYPED_URLS, storage_key2, metadata));
+
+ MetadataBatch metadata_batch;
+ EXPECT_TRUE(GetAllSyncMetadata(syncer::TYPED_URLS, &metadata_batch));
+
+ EXPECT_TRUE(metadata_batch.GetModelTypeState().initial_sync_done());
+
+ EntityMetadataMap metadata_records = metadata_batch.TakeAllMetadata();
+
+ EXPECT_EQ(metadata_records.size(), 2u);
+ EXPECT_EQ(metadata_records[storage_key].sequence_number(), 1);
+ EXPECT_EQ(metadata_records[storage_key2].sequence_number(), 2);
+
+ // Now check that a model type state update replaces the old value
+ model_type_state.set_initial_sync_done(false);
+ EXPECT_TRUE(UpdateModelTypeState(syncer::TYPED_URLS, model_type_state));
+
+ EXPECT_TRUE(GetAllSyncMetadata(syncer::TYPED_URLS, &metadata_batch));
+ EXPECT_FALSE(metadata_batch.GetModelTypeState().initial_sync_done());
+}
+
+TEST_F(TypedURLSyncMetadataDatabaseTest, TypedURLWriteThenDeleteSyncMetadata) {
+ EntityMetadata metadata;
+ MetadataBatch metadata_batch;
+ std::string storage_key = "storage_key";
+ ModelTypeState model_type_state;
+
+ model_type_state.set_initial_sync_done(true);
+
+ metadata.set_client_tag_hash("client_hash");
+
+ // Write the data into the store.
+ EXPECT_TRUE(UpdateSyncMetadata(syncer::TYPED_URLS, storage_key, metadata));
+ EXPECT_TRUE(UpdateModelTypeState(syncer::TYPED_URLS, model_type_state));
+ // Delete the data we just wrote.
+ EXPECT_TRUE(ClearSyncMetadata(syncer::TYPED_URLS, storage_key));
+ // It shouldn't be there any more.
+ EXPECT_TRUE(GetAllSyncMetadata(syncer::TYPED_URLS, &metadata_batch));
+
+ EntityMetadataMap metadata_records = metadata_batch.TakeAllMetadata();
+ EXPECT_EQ(metadata_records.size(), 0u);
+
+ // Now delete the model type state.
+ EXPECT_TRUE(ClearModelTypeState(syncer::TYPED_URLS));
+ EXPECT_TRUE(GetAllSyncMetadata(syncer::TYPED_URLS, &metadata_batch));
+ EXPECT_EQ(ModelTypeState().SerializeAsString(),
+ metadata_batch.GetModelTypeState().SerializeAsString());
+}
+
+TEST_F(TypedURLSyncMetadataDatabaseTest, TypedURLCorruptSyncMetadata) {
+ MetadataBatch metadata_batch;
+ sql::Statement s(GetDB().GetUniqueStatement(
+ "INSERT OR REPLACE INTO typed_url_sync_metadata "
+ "(storage_key, value) VALUES(?, ?)"));
+ s.BindString(0, "storage_key");
+ s.BindString(1, "unparseable");
+ EXPECT_TRUE(s.Run());
+
+ EXPECT_FALSE(GetAllSyncMetadata(syncer::TYPED_URLS, &metadata_batch));
+}
+
+TEST_F(TypedURLSyncMetadataDatabaseTest, TypedURLCorruptModelTypeState) {
+ MetadataBatch metadata_batch;
+ sql::Statement s(GetDB().GetUniqueStatement(
+ "INSERT OR REPLACE INTO typed_url_model_type_state "
+ "(rowid, value) VALUES(1, ?)"));
+ s.BindString(0, "unparseable");
+ EXPECT_TRUE(s.Run());
+
+ EXPECT_FALSE(GetAllSyncMetadata(syncer::TYPED_URLS, &metadata_batch));
+}
+
+} // namespace history

Powered by Google App Engine
This is Rietveld 408576698