Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: components/history/core/browser/in_memory_database.cc

Issue 2721713002: [sync] Add typed url sync metadata to the history db (Closed)
Patch Set: update for comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/history/core/browser/in_memory_database.cc
diff --git a/components/history/core/browser/in_memory_database.cc b/components/history/core/browser/in_memory_database.cc
index b99e202f21da899931a28a34a63fd8128e721f86..e06941f3ceb5a2408d5007912adb77a8c0cf29d0 100644
--- a/components/history/core/browser/in_memory_database.cc
+++ b/components/history/core/browser/in_memory_database.cc
@@ -102,11 +102,10 @@ bool InMemoryDatabase::InitFromDisk(const base::FilePath& history_name) {
// Insert keyword search related URLs.
begin_load = base::TimeTicks::Now();
- if (!db_.Execute(
- "INSERT OR IGNORE INTO urls SELECT u.id, u.url, u.title, u.visit_count, "
- "u.typed_count, u.last_visit_time, u.hidden, u.favicon_id "
- "FROM history.urls u JOIN history.keyword_search_terms kst "
- "WHERE u.typed_count = 0 AND u.id = kst.url_id")) {
+ if (!db_.Execute("INSERT OR IGNORE INTO urls SELECT u.id, u.url, u.title, "
+ "u.visit_count, u.typed_count, u.last_visit_time, u.hidden "
+ "FROM history.urls u JOIN history.keyword_search_terms kst "
+ "WHERE u.typed_count = 0 AND u.id = kst.url_id")) {
// Unable to get data from the history database. This is OK, the file may
// just not exist yet.
}

Powered by Google App Engine
This is Rietveld 408576698