src/x64/macro-assembler-x64.h - Issue 272163002: Make BitField3 a raw uint32 field, and move to the start of the map.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/macro-assembler-x64.h

Issue 272163002: Make BitField3 a raw uint32 field, and move to the start of the map. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/macro-assembler-x64.h

diff --git a/src/x64/macro-assembler-x64.h b/src/x64/macro-assembler-x64.h

index d9893d62109a7db7fe8e13958462a2cc26e79924..8f0d6724e0f9daa6e37713f27e4bd32b75f7c165 100644

--- a/src/x64/macro-assembler-x64.h

+++ b/src/x64/macro-assembler-x64.h

@@ -1011,11 +1011,10 @@ class MacroAssembler: public Assembler {

template<typename Field>

void DecodeField(Register reg) {

- static const int shift = Field::kShift + kSmiShift;

+ static const int shift = Field::kShift;

static const int mask = Field::kMask >> Field::kShift;

- shrp(reg, Immediate(shift));

- andp(reg, Immediate(mask));

- shlp(reg, Immediate(kSmiShift));

+ shrl(reg, Immediate(shift));

+ andl(reg, Immediate(mask));

}

// Abort execution if argument is not a number, enabled via --debug-code.

« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | src/x64/macro-assembler-x64.cc » ('j') | no next file with comments »