simulation_test_ng: initial CL

recipe_engine/simulation_test.py

 # Copyright 2014 The LUCI Authors. All rights reserved.
 # Use of this source code is governed under the Apache License, Version 2.0
 # that can be found in the LICENSE file.
 
 """Provides simulator test coverage for individual recipes."""
 
 import StringIO
 import copy
 import json
 import logging
@@ skipping 155 matching lines @@
   # Make sure disabling strict coverage also disables our additional check
   # for module coverage. Note that coverage will still raise an error if
   # the module is executed by any of the tests, but having less than 100%
   # coverage.
   for module in all_modules:
     mod = _UNIVERSE_VIEW.load_recipe_module(module)
     # Recipe modules can only be covered by tests inside the same module.
     # To make transition possible for existing code (which will require
     # writing tests), a temporary escape hatch is added.
     # TODO(phajdan.jr): remove DISABLE_STRICT_COVERAGE (crbug/693058).
-    if (getattr(mod, 'DISABLE_STRICT_COVERAGE', False)):
+    if mod.DISABLE_STRICT_COVERAGE:
       covered_modules.add(module)
       base_covers.append(os.path.join(
           _UNIVERSE_VIEW.module_dir, module, '*.py'))
 
   for recipe_path, recipe_name in _UNIVERSE_VIEW.loop_over_recipes():
     try:
       recipe = _UNIVERSE_VIEW.load_recipe(recipe_name)
       test_api = loader.create_test_api(recipe.LOADED_DEPS, _UNIVERSE_VIEW)
 
       covers = [recipe_path] + base_covers
@@ skipping 46 matching lines @@
       logging.warn("Ignoring %s environment variable." % env_var)
       os.environ.pop(env_var)
 
   global _UNIVERSE_VIEW
   _UNIVERSE_VIEW = universe_view
   global _ENGINE_FLAGS
   _ENGINE_FLAGS = engine_flags
 
   expect_tests_main('recipe_simulation_test', GenerateTests,
                     cover_omit=cover_omit(), args=args)