third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc - Issue 2721613003: [LayoutNG] Move remaining ng_units structs to their own files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc

Issue 2721613003: [LayoutNG] Move remaining ng_units structs to their own files (Closed)

Patch Set: Don't export NGBoxStrut for now Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/BUILD.gn ('K') | « third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.h ('k') | third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc b/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc

index 4e5ec779cb6b045f835252e2807cf136c78e819c..beaa95dfbf5b16a7acc0be93d133d16203776e08 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc

@@ -106,11 +106,11 @@ RefPtr<NGLayoutResult> NGOutOfFlowLayoutPart::LayoutDescendant(

static_position.offset -= container_border_physical_offset_;

RefPtr<NGLayoutResult> layout_result = nullptr;

- Optional<MinAndMaxContentSizes> inline_estimate;

+ Optional<MinMaxContentSize> inline_estimate;

Optional<LayoutUnit> block_estimate;

if (AbsoluteNeedsChildInlineSize(descendant.Style())) {

- inline_estimate = descendant.ComputeMinAndMaxContentSizes();

+ inline_estimate = descendant.ComputeMinMaxContentSize();

}

NGAbsolutePhysicalPosition node_position =