Fix matching Roboto Bold for src: local("Roboto Regular")

third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp

 /*
  * Copyright (C) 2006, 2007 Apple Computer, Inc.
  * Copyright (c) 2006, 2007, 2008, 2009, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 329 matching lines @@
   CString name;
   sk_sp<SkTypeface> tf = createTypeface(fontDescription, creationParams, name);
   // Windows will always give us a valid pointer here, even if the face name
   // is non-existent. We have to double-check and see if the family name was
   // really used.
   if (!tf || !typefacesMatchesFamily(tf.get(), creationParams.family())) {
     AtomicString adjustedName;
     FontWeight variantWeight;
     FontStretch variantStretch;
 
+    // TODO: crbug.com/627143 LocalFontFaceSource.cpp, which implements
+    // retrieving src: local() font data uses getFontData, which in turn comes
+    // here, to retrieve fonts from the cache and specifies the argument to
+    // local() as family name. So we do not match by full font name or
+    // postscript name as the spec says:
+    // https://drafts.csswg.org/css-fonts-3/#src-desc
+
+    // Prevent one side effect of the suffix translation below where when
+    // matching local("Roboto Regular") it tries to find the closest match even
+    // though that can be a bold font in case of Roboto Bold.
+    if (alternateFontName == AlternateFontName::LocalUniqueFace) {
+      return nullptr;
+    }
+
     if (alternateFontName == AlternateFontName::LastResort) {
       if (!tf)
         return nullptr;
     } else if (typefacesHasWeightSuffix(creationParams.family(), adjustedName,
                                         variantWeight)) {
       FontFaceCreationParams adjustedParams(adjustedName);
       FontDescription adjustedFontDescription = fontDescription;
       adjustedFontDescription.setWeight(variantWeight);
       tf = createTypeface(adjustedFontDescription, adjustedParams, name);
       if (!tf || !typefacesMatchesFamily(tf.get(), adjustedName))
@@ skipping 58 matching lines @@
     if (typefacesMatchesFamily(tf.get(), family)) {
       result->setMinSizeForSubpixel(minSizeForSubpixelForFont);
       break;
     }
   }
 
   return result;
 }
 
 }  // namespace blink