Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2721573002: Status file update after analyzer->fasta dartk switch (Closed)

Created:
3 years, 9 months ago by kustermann
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org, ahe
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Status file update after analyzer->fasta dartk switch R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/ce5906145d83558f2a526d7a5ed40660d5465920

Patch Set 1 #

Total comments: 3

Patch Set 2 : Add 2 more failures (maybe introduced today) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -576 lines) Patch
M tests/language/language_kernel.status View 1 8 chunks +14 lines, -576 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kustermann
https://codereview.chromium.org/2721573002/diff/1/tests/language/language_kernel.status File tests/language/language_kernel.status (left): https://codereview.chromium.org/2721573002/diff/1/tests/language/language_kernel.status#oldcode24 tests/language/language_kernel.status:24: arg_param_trailing_comma_test/202: DartkCrash These were duplicates for some reason :-/ ...
3 years, 9 months ago (2017-02-27 11:26:27 UTC) #2
Vyacheslav Egorov (Google)
lgtm
3 years, 9 months ago (2017-02-27 11:33:19 UTC) #3
kustermann
3 years, 9 months ago (2017-02-27 11:37:31 UTC) #4
kustermann
3 years, 9 months ago (2017-02-27 11:45:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ce5906145d83558f2a526d7a5ed40660d5465920 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698