Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Issue 2721543003: Remove dartk and DFE workers support from testing scripts and kernel-service. (Closed)

Created:
3 years, 9 months ago by Vyacheslav Egorov (Google)
Modified:
3 years, 9 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove dartk and DFE workers support from testing scripts and kernel-service. We only support running -c dark and -c dartkp configuration through Kernel isolate and fasta in non-batch mode. R=kustermann@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/b026aed3cf46df0eda671de6737bf2dbadc4aa0e

Patch Set 1 #

Patch Set 2 : Remove preArguments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -347 lines) Patch
M tools/testing/dart/compiler_configuration.dart View 7 chunks +8 lines, -46 lines 0 comments Download
M tools/testing/dart/runtime_configuration.dart View 2 chunks +1 line, -4 lines 0 comments Download
M tools/testing/dart/test_options.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 1 9 chunks +4 lines, -135 lines 0 comments Download
M utils/kernel-service/kernel-service.dart View 11 chunks +27 lines, -156 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Vyacheslav Egorov (Google)
3 years, 9 months ago (2017-02-27 12:22:10 UTC) #1
kustermann
LGTM
3 years, 9 months ago (2017-02-27 12:28:58 UTC) #2
Vyacheslav Egorov (Google)
3 years, 9 months ago (2017-02-27 12:31:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b026aed3cf46df0eda671de6737bf2dbadc4aa0e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698