Very simple version of Isolates.

runtime/vm/isolate.cc

Index: runtime/vm/isolate.cc
diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc
index d8ab9a53852f0d8d4789fda623e5a59226beacad..2aab77f2f5c349ce9ca8ab1aab8cc31a8fcc816b 100644
--- a/runtime/vm/isolate.cc
+++ b/runtime/vm/isolate.cc
@@ -510,6 +510,7 @@ static bool RunIsolate(uword parameter) {
 
     Object& result = Object::Handle();
     result = state->ResolveFunction();
+    bool is_function_spawn = state->library_url() != NULL;

[Ivan Posva, 2013/10/25 07:01:46]

I find this is rather brittle and would suggest that you keep the fact whether
this was spawnFunction or spawnUri in an IsolateSpawnState::was_spawn_uri()
method. Within that method it is OK to rely on the above check, but then it is
all encapsulated within the IsolateSpawnState.

[floitsch, 2013/10/25 13:11:01]

Done.

     delete state;
     state = NULL;
     if (result.IsError()) {
@@ -519,7 +520,27 @@ static bool RunIsolate(uword parameter) {
     ASSERT(result.IsFunction());
     Function& func = Function::Handle(isolate);
     func ^= result.raw();
-    result = DartEntry::InvokeFunction(func, Object::empty_array());
+    func = func.ImplicitClosureFunction();
+
+    // Instead of directly invoking the entry point we call '_startIsolate' with

[Ivan Posva, 2013/10/25 07:01:46]

This trampoline through _startIsolate will have the effect that this function
will be shown in the stack traces for spawned isolates. I am not concerned about
exposing this, but I just wanted to mention it.

[floitsch, 2013/10/25 13:11:01]

Yes. It's something we can live with in the near future.
Eventually we want to remove the trampoline.

+    // the entry point as argument. The '_startIsolate' function will
+    // communicate with the spawner to receive the initial message before it
+    // executes the real entry point.
+    // Since this function ("RunIsolate") is used for both Isolate.spawn and
+    // Isolate.spawnUri we also send a boolean flag as argument so that the
+    // "_startIsolate" function can act corresponding to how the isolate was
+    // created.
+    const Array& args = Array::Handle(Array::New(2));
+    args.SetAt(0, Instance::Handle(func.ImplicitStaticClosure()));
+    args.SetAt(1, is_function_spawn ? Bool::True() : Bool::False());
+
+    const Library& lib = Library::Handle(Library::IsolateLibrary());
+    const String& entry_name = String::Handle(String::New("_startIsolate"));
+    const Function& entry_point =
+        Function::Handle(lib.LookupLocalFunction(entry_name));
+    ASSERT(entry_point.IsFunction() && !entry_point.IsNull());
+
+    result = DartEntry::InvokeFunction(entry_point, args);
     if (result.IsError()) {
       StoreError(isolate, result);
       return false;
@@ -977,8 +998,7 @@ static char* GetRootScriptUri(Isolate* isolate) {
 }
 
 
-IsolateSpawnState::IsolateSpawnState(const Function& func,
-                                     const Function& callback_func)
+IsolateSpawnState::IsolateSpawnState(const Function& func)
     : isolate_(NULL),
       script_url_(NULL),
       library_url_(NULL),
@@ -993,12 +1013,7 @@ IsolateSpawnState::IsolateSpawnState(const Function& func,
 
   const String& func_name = String::Handle(func.name());
   function_name_ = strdup(func_name.ToCString());
-  if (!callback_func.IsNull()) {
-    const String& callback_name = String::Handle(callback_func.name());
-    exception_callback_name_ = strdup(callback_name.ToCString());
-  } else {
-    exception_callback_name_ = strdup("_unhandledExceptionCallback");
-  }
+  exception_callback_name_ = strdup("_unhandledExceptionCallback");
 }