Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1892)

Unified Diff: utils/testrunner/testrunner.dart

Issue 27215002: Very simple version of Isolates. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/testrunner/standard_test_runner.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/testrunner/testrunner.dart
diff --git a/utils/testrunner/testrunner.dart b/utils/testrunner/testrunner.dart
index 7ecf8ac985d5c0b833bb9df73365db95f67582ed..0292b2c5f7b7abf3f4204af530a656f83b9c3e15 100755
--- a/utils/testrunner/testrunner.dart
+++ b/utils/testrunner/testrunner.dart
@@ -256,8 +256,6 @@ void spawnTasks(Map config, List testFiles) {
// We could later print a summary report here.
}
});
- SendPort s = spawnUri(config['pipeline']);
-
// Get the names of the source and target test files and containing
// directories.
var testPath = new Path(testfile);
@@ -279,14 +277,12 @@ void spawnTasks(Map config, List testFiles) {
config['pub'], config['runtime']);
_testDir = targetDir;
}
- if (f == null) {
- s.send(config, port.toSendPort());
- } else {
- f.then((_) {
- s.send(config, port.toSendPort());
- });
- break; // Don't do any more until pub is done.
- }
+ var response = new ReceivePort();
+ spawnUri(config['pipeline'], [], response)
+ .then((_) => f)
+ .then((_) => response.first)
+ .then((s) { s.send([config, port.sendPort]); });
+ if (f != null) break; // Don't do any more until pub is done.
}
}
« no previous file with comments | « utils/testrunner/standard_test_runner.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698