Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2721443002: Switch -c dartk/dartkp configuration to use fasta. (Closed)

Created:
3 years, 9 months ago by Vyacheslav Egorov (Google)
Modified:
3 years, 9 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Switch -c dartk/dartkp configuration to use fasta. R=kustermann@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/de56824429a59dffa06cf0bc34b134515fa53bd2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5854 lines, -122 lines) Patch
M tests/co19/co19-kernel.status View 6 chunks +2738 lines, -67 lines 0 comments Download
M tests/kernel/kernel.status View 2 chunks +4 lines, -1 line 0 comments Download
M tests/language/language_kernel.status View 10 chunks +3085 lines, -45 lines 0 comments Download
M tools/testing/dart/compiler_configuration.dart View 4 chunks +25 lines, -8 lines 0 comments Download
M tools/testing/dart/runtime_configuration.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tools/testing/dart/test_options.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Vyacheslav Egorov (Google)
3 years, 9 months ago (2017-02-26 14:42:00 UTC) #1
kustermann
Rubberstamp lgtm
3 years, 9 months ago (2017-02-26 19:32:51 UTC) #2
Vyacheslav Egorov (Google)
3 years, 9 months ago (2017-02-26 19:39:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
de56824429a59dffa06cf0bc34b134515fa53bd2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698