Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1156)

Issue 272143002: Revert of Fix webkit_unit_tests to use the threaded parser and enable everywhere. (Closed)

Created:
6 years, 7 months ago by falken
Modified:
6 years, 7 months ago
CC:
eseidel
Visibility:
Public.

Description

Revert of Fix webkit_unit_tests to use the threaded parser and enable everywhere. (https://codereview.chromium.org/271793007/) Reason for revert: Sorry to revert this patch. The assert it adds is getting hit in webkit_unit_tests on WebKit Mac 10.6 (dbg). Log: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20%28dbg%29/builds/14735/steps/webkit_unit_tests/logs/stdio Snippet from log: ASSERTION FAILED: !testClientForFrame(m_webView->mainFrame())->isLoading() ../../third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp(271) : void blink::FrameTestHelpers::WebViewHelper::reset() Original issue's description: > Fix webkit_unit_tests to use the threaded parser and enable everywhere. > > In order to support the threaded parser, FrameTestHelpers utilities has > been updated to magically wait for loads to finish. There are also > several new helpers for other common operations in tests that > understand how to wait for the threaded parser to complete. > > Tests that need to interleave more complicated operations can fall back > to pumpPendingRequestsDoNotUse(). Most tests should prefer the new > helper utilities though. > > BUG=366354 > R=abarth@chromium.org, eseidel@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173731 TBR=abarth@chromium.org,eseidel@chromium.org,dcheng@chromium.org NOTREECHECKS=true NOTRY=true BUG=366354 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173737

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -297 lines) Patch
M Source/core/frame/Settings.in View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/AssociatedURLLoaderTest.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M Source/web/tests/CompositedLayerMappingTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/tests/FrameTestHelpers.h View 3 chunks +2 lines, -26 lines 0 comments Download
M Source/web/tests/FrameTestHelpers.cpp View 8 chunks +5 lines, -149 lines 0 comments Download
M Source/web/tests/MHTMLTest.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M Source/web/tests/PageSerializerTest.cpp View 2 chunks +12 lines, -1 line 0 comments Download
M Source/web/tests/PinchViewportTest.cpp View 3 chunks +8 lines, -0 lines 0 comments Download
M Source/web/tests/PopupMenuTest.cpp View 5 chunks +13 lines, -1 line 0 comments Download
M Source/web/tests/PrerenderingTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/tests/ScrollingCoordinatorChromiumTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/tests/ViewportTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 45 chunks +109 lines, -93 lines 0 comments Download
M Source/web/tests/WebPageNewSerializerTest.cpp View 2 chunks +16 lines, -1 line 0 comments Download
M Source/web/tests/WebPageSerializerTest.cpp View 2 chunks +12 lines, -1 line 0 comments Download
M Source/web/tests/WebViewTest.cpp View 4 chunks +12 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
falken
Created Revert of Fix webkit_unit_tests to use the threaded parser and enable everywhere.
6 years, 7 months ago (2014-05-09 08:36:28 UTC) #1
falken
The CQ bit was checked by falken@chromium.org
6 years, 7 months ago (2014-05-09 08:40:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/272143002/1
6 years, 7 months ago (2014-05-09 08:41:25 UTC) #3
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 08:42:04 UTC) #4
Message was sent while issue was closed.
Change committed as 173737

Powered by Google App Engine
This is Rietveld 408576698