third_party/WebKit/Source/web/WebFrame.cpp - Issue 2721423003: Reset Frame::m_hasReceivedUserGesture for main frames on navigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebFrame.cpp

Issue 2721423003: Reset Frame::m_hasReceivedUserGesture for main frames on navigation (Closed)

Patch Set: One bit, reset for main frames on commit Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebFrame.cpp

diff --git a/third_party/WebKit/Source/web/WebFrame.cpp b/third_party/WebKit/Source/web/WebFrame.cpp

index 59df86f0c71e8dce1b85eb387ee2e9d37f4e6b41..8b56364cd549f6fe134d0be8e19cb1059789eb4e 100644

--- a/third_party/WebKit/Source/web/WebFrame.cpp

+++ b/third_party/WebKit/Source/web/WebFrame.cpp

@@ -110,7 +110,7 @@ bool WebFrame::swap(WebFrame* frame) {

uniqueName);

}

- if (oldFrame->hasReceivedUserGesture())

+ if (m_parent && oldFrame->hasReceivedUserGesture())

frame->toImplBase()->frame()->setDocumentHasReceivedUserGesture();

frame->toImplBase()->frame()->getWindowProxyManager()->setGlobals(globals);

« no previous file with comments | « third_party/WebKit/Source/core/frame/LocalFrame.cpp ('k') | no next file » | no next file with comments »