Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2721403006: Split NativeData (Closed)

Created:
3 years, 9 months ago by Johnni Winther
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Split NativeData - into NativeData, NativeDataBuilder and NativeDataImpl + add JavaScriptBackendTarget to move all .isNative queries to NativeData (more implementation should be moved here) R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/6d3bf72448b04da8bf0d13d3e7a1ac4b8a845c09

Patch Set 1 #

Total comments: 8

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+338 lines, -205 lines) Patch
M pkg/compiler/lib/src/common/resolution.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_engine.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/node_tracer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 16 chunks +71 lines, -54 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_helpers.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_serialization.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_usage.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/impact_transformer.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_interop_analysis.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/native_data.dart View 1 6 chunks +116 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/patch_resolver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 4 chunks +17 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 9 chunks +18 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart View 4 chunks +12 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 5 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/native/behavior.dart View 4 chunks +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 8 chunks +19 lines, -17 lines 0 comments Download
M pkg/compiler/lib/src/native/ssa.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/null_compiler_output.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 11 chunks +14 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 4 chunks +7 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/types/types.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/world_builder.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/world.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/serialization/native_data_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Johnni Winther
3 years, 9 months ago (2017-03-02 12:21:29 UTC) #3
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2721403006/diff/1/pkg/compiler/lib/src/js_backend/native_data.dart File pkg/compiler/lib/src/js_backend/native_data.dart (right): https://codereview.chromium.org/2721403006/diff/1/pkg/compiler/lib/src/js_backend/native_data.dart#newcode32 pkg/compiler/lib/src/js_backend/native_data.dart:32: /// (`@Native(...)` or the `native` pseudo keyword) allowed ...
3 years, 9 months ago (2017-03-14 00:15:59 UTC) #4
Johnni Winther
https://codereview.chromium.org/2721403006/diff/1/pkg/compiler/lib/src/js_backend/native_data.dart File pkg/compiler/lib/src/js_backend/native_data.dart (right): https://codereview.chromium.org/2721403006/diff/1/pkg/compiler/lib/src/js_backend/native_data.dart#newcode32 pkg/compiler/lib/src/js_backend/native_data.dart:32: /// (`@Native(...)` or the `native` pseudo keyword) allowed for ...
3 years, 9 months ago (2017-03-14 15:48:04 UTC) #5
Johnni Winther
3 years, 9 months ago (2017-03-14 15:54:27 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
6d3bf72448b04da8bf0d13d3e7a1ac4b8a845c09 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698