ios/chrome/browser/ui/history/favicon_view_provider_unittest.mm - Issue 2721363002: Extend LargeIconService to fetch missing favicons from a Google server

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/history/favicon_view_provider_unittest.mm

Issue 2721363002: Extend LargeIconService to fetch missing favicons from a Google server (Closed)

Patch Set: Add fallback_opts=TYPE Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/history/favicon_view_provider_unittest.mm

diff --git a/ios/chrome/browser/ui/history/favicon_view_provider_unittest.mm b/ios/chrome/browser/ui/history/favicon_view_provider_unittest.mm

index b6b3d83ed58202ec9b272bb95daedfb4365e49bb..6ec3886f61082cd040f568489f8973c2a732f5f3 100644

--- a/ios/chrome/browser/ui/history/favicon_view_provider_unittest.mm

+++ b/ios/chrome/browser/ui/history/favicon_view_provider_unittest.mm

@@ -80,7 +80,8 @@ class FaviconViewProviderTest : public PlatformTest {

DCHECK_CURRENTLY_ON(web::WebThread::UI);

PlatformTest::SetUp();

large_icon_service_.reset(new favicon::LargeIconService(

- &mock_favicon_service_, base::ThreadTaskRunnerHandle::Get()));

+ &mock_favicon_service_, base::ThreadTaskRunnerHandle::Get(),

+ /*image_fetcher=*/nullptr));

EXPECT_CALL(mock_favicon_service_, GetLargestRawFaviconForPageURL(

GURL(kTestFaviconURL), _, _, _, _))