ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm - Issue 2721363002: Extend LargeIconService to fetch missing favicons from a Google server

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm

Issue 2721363002: Extend LargeIconService to fetch missing favicons from a Google server (Closed)

Patch Set: Addressed comments. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/favicon/core/favicon_service_impl.cc ('K') | « ios/chrome/browser/ui/history/favicon_view_provider_unittest.mm ('k') | ios/chrome/browser/ui/reading_list/reading_list_coordinator_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm

diff --git a/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm b/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm

index 47e643f42328eed41c95b224c6fb6f6cae93e129..f6ef1f4117165ecea7e11d4565171a7a55a74c90 100644

--- a/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm

+++ b/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm

@@ -60,7 +60,8 @@ class ReadingListCollectionViewControllerTest : public testing::Test {

reading_list_model_.reset(new ReadingListModelImpl(

nullptr, nullptr, base::MakeUnique<base::DefaultClock>()));

large_icon_service_.reset(new favicon::LargeIconService(

- &mock_favicon_service_, base::ThreadTaskRunnerHandle::Get()));

+ &mock_favicon_service_, base::ThreadTaskRunnerHandle::Get(),

+ /*image_fetcher=*/nullptr));

reading_list_view_controller_.reset(

[[ReadingListCollectionViewController alloc]

initWithModel:reading_list_model_.get()