Chromium Code Reviews| Index: components/favicon/core/favicon_service.h |
| diff --git a/components/favicon/core/favicon_service.h b/components/favicon/core/favicon_service.h |
| index 10a8174747ea6890cb385dae6e1d2b2649ff97c1..165bccc22068ef5427c41e67f15970819f065171 100644 |
| --- a/components/favicon/core/favicon_service.h |
| +++ b/components/favicon/core/favicon_service.h |
| @@ -189,6 +189,20 @@ class FaviconService : public KeyedService { |
| favicon_base::IconType icon_type, |
| const gfx::Image& image) = 0; |
| + // Same as SetFavicons with three differences: |
|
pkotwicz
2017/03/21 18:20:29
Nit: SetFavicons -> SetFavicons()
mastiz
2017/03/22 09:46:53
Done.
|
| + // 1) It will be a no-op if there is an existing cached favicon for *any* type |
| + // for |page_url|. |
| + // 2) If |icon_url| is known to the database, |bitmaps| will be ignored (i.e. |
| + // the icon won't be overwritten) but the mappings from |page_url| to |
| + // |icon_url| will be stored (conditioned to point 1 above). |
| + // 3) If |icon_url| is stored, it will be marked as expired. |
| + // The callback will receive whether the write actually happened. |
| + virtual void SetLastResortFavicons(const GURL& page_url, |
| + const GURL& icon_url, |
| + favicon_base::IconType icon_type, |
| + const gfx::Image& image, |
| + base::Callback<void(bool)> callback) = 0; |
| + |
| // Avoid repeated requests to download missing favicon. |
| virtual void UnableToDownloadFavicon(const GURL& icon_url) = 0; |
| virtual bool WasUnableToDownloadFavicon(const GURL& icon_url) const = 0; |