Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: components/history/core/browser/history_service.h

Issue 2721363002: Extend LargeIconService to fetch missing favicons from a Google server (Closed)
Patch Set: Addressed comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/history/core/browser/history_service.h
diff --git a/components/history/core/browser/history_service.h b/components/history/core/browser/history_service.h
index dd6b19aa490f1898e9413cc7fa355269966a4ef5..87cfd26bdaa6d1163d535cd6ec5ec2f507aa8929 100644
--- a/components/history/core/browser/history_service.h
+++ b/components/history/core/browser/history_service.h
@@ -761,6 +761,14 @@ class HistoryService : public syncer::SyncableService, public KeyedService {
const GURL& icon_url,
const std::vector<SkBitmap>& bitmaps);
+ // Same as SetFavicons with two differences: a) the favicon will be initially
+ // set as expired; b) it will be a no-op if there is an existing cached
+ // favicon for *any* type for |page_url|.
+ void SetExpiredFaviconsIfNoneKnown(const GURL& page_url,
+ favicon_base::IconType icon_type,
+ const GURL& icon_url,
+ const std::vector<SkBitmap>& bitmaps);
+
// Used by the FaviconService to mark the favicon for the page as being out
// of date.
void SetFaviconsOutOfDateForPage(const GURL& page_url);

Powered by Google App Engine
This is Rietveld 408576698