Extend LargeIconService to fetch missing favicons from a Google server

components/favicon/core/favicon_service_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/favicon/core/favicon_service_impl.h"
 
 #include <stddef.h>
 #include <cmath>
 #include <utility>
 
@@ skipping 213 matching lines @@
     // Don't save if the scale isn't one of supported favicon scales.
     if (std::find(favicon_scales.begin(), favicon_scales.end(),
                   image_reps[i].scale()) == favicon_scales.end()) {
       continue;
     }
     bitmaps.push_back(image_reps[i].sk_bitmap());
   }
   history_service_->SetFavicons(page_url, icon_type, icon_url, bitmaps);
 }
 
+void FaviconServiceImpl::SetLastResortFavicons(
+    const GURL& page_url,
+    const GURL& icon_url,
+    favicon_base::IconType icon_type,
+    const gfx::Image& image,
+    base::Callback<void(bool)> callback) {
+  gfx::ImageSkia image_skia = image.AsImageSkia();

[sdefresne, 2017/03/23 10:24:41]

This code looks like it is a copy-n-paste version of SetFavicons() except for
the history_service method that is called. Can you avoid duplicating the code?
It looks like this create a std::vector<SkBitmap> from a gfx::Image and does not
access "this", so can probably be extracted to an helper method.

[mastiz, 2017/03/23 12:03:23]

Done, thanks!

+  image_skia.EnsureRepsForSupportedScales();
+  const std::vector<gfx::ImageSkiaRep>& image_reps = image_skia.image_reps();
+  std::vector<SkBitmap> bitmaps;
+  const std::vector<float> favicon_scales = favicon_base::GetFaviconScales();
+  for (size_t i = 0; i < image_reps.size(); ++i) {
+    // Don't save if the scale isn't one of supported favicon scales.
+    if (std::find(favicon_scales.begin(), favicon_scales.end(),
+                  image_reps[i].scale()) == favicon_scales.end()) {
+      continue;
+    }
+    bitmaps.push_back(image_reps[i].sk_bitmap());
+  }
+  history_service_->SetLastResortFavicons(page_url, icon_type, icon_url,
+                                          bitmaps, callback);
+}
+
 void FaviconServiceImpl::UnableToDownloadFavicon(const GURL& icon_url) {
   MissingFaviconURLHash url_hash = base::Hash(icon_url.spec());
   missing_favicon_urls_.insert(url_hash);
 }
 
 bool FaviconServiceImpl::WasUnableToDownloadFavicon(
     const GURL& icon_url) const {
   MissingFaviconURLHash url_hash = base::Hash(icon_url.spec());
   return missing_favicon_urls_.find(url_hash) != missing_favicon_urls_.end();
 }
@@ skipping 42 matching lines @@
     const std::vector<favicon_base::FaviconRawBitmapResult>&
         favicon_bitmap_results) {
   TRACE_EVENT0(
       "browser",
       "FaviconServiceImpl::RunFaviconRawBitmapCallbackWithBitmapResults");
   callback.Run(
       ResizeFaviconBitmapResult(favicon_bitmap_results, desired_size_in_pixel));
 }
 
 }  // namespace favicon