Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: components/favicon/core/BUILD.gn

Issue 2721363002: Extend LargeIconService to fetch missing favicons from a Google server (Closed)
Patch Set: Addressed comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 static_library("core") { 5 static_library("core") {
6 sources = [ 6 sources = [
7 "fallback_url_util.cc", 7 "fallback_url_util.cc",
8 "fallback_url_util.h", 8 "fallback_url_util.h",
9 "favicon_client.h", 9 "favicon_client.h",
10 "favicon_driver.cc", 10 "favicon_driver.cc",
(...skipping 12 matching lines...) Expand all
23 "favicon_util.cc", 23 "favicon_util.cc",
24 "favicon_util.h", 24 "favicon_util.h",
25 "large_icon_service.cc", 25 "large_icon_service.cc",
26 "large_icon_service.h", 26 "large_icon_service.h",
27 ] 27 ]
28 28
29 deps = [ 29 deps = [
30 "//base", 30 "//base",
31 "//base:i18n", 31 "//base:i18n",
32 "//components/bookmarks/browser", 32 "//components/bookmarks/browser",
33 "//components/data_use_measurement/core",
33 "//components/favicon_base", 34 "//components/favicon_base",
34 "//components/history/core/browser", 35 "//components/history/core/browser",
36 "//components/image_fetcher",
35 "//components/keyed_service/core", 37 "//components/keyed_service/core",
36 "//net:net", 38 "//net:net",
37 "//skia", 39 "//skia",
38 "//ui/base", 40 "//ui/base",
39 "//ui/gfx", 41 "//ui/gfx",
40 "//url", 42 "//url",
41 ] 43 ]
42 if (!is_ios) { 44 if (!is_ios) {
43 sources += [ 45 sources += [
44 "fallback_icon_client.h", 46 "fallback_icon_client.h",
45 "fallback_icon_service.cc", 47 "fallback_icon_service.cc",
46 "fallback_icon_service.h", 48 "fallback_icon_service.h",
47 ] 49 ]
48 } 50 }
49 } 51 }
50 52
51 source_set("unit_tests") { 53 source_set("unit_tests") {
52 testonly = true 54 testonly = true
53 sources = [ 55 sources = [
54 "fallback_url_util_unittest.cc", 56 "fallback_url_util_unittest.cc",
55 "favicon_handler_unittest.cc", 57 "favicon_handler_unittest.cc",
56 "favicon_service_impl_unittest.cc", 58 "favicon_service_impl_unittest.cc",
57 "large_icon_service_unittest.cc", 59 "large_icon_service_unittest.cc",
58 ] 60 ]
59 61
60 deps = [ 62 deps = [
61 ":core", 63 ":core",
62 "//base", 64 "//base",
65 "//base/test:test_support",
63 "//components/favicon/core/test:test_support", 66 "//components/favicon/core/test:test_support",
64 "//components/favicon_base", 67 "//components/favicon_base",
65 "//components/history/core/browser:browser", 68 "//components/history/core/browser:browser",
66 "//components/history/core/test:test", 69 "//components/history/core/test:test",
70 "//components/image_fetcher",
67 "//skia", 71 "//skia",
68 "//testing/gmock", 72 "//testing/gmock",
69 "//testing/gtest", 73 "//testing/gtest",
70 "//ui/base", 74 "//ui/base",
71 "//ui/gfx", 75 "//ui/gfx",
72 "//ui/gfx:test_support", 76 "//ui/gfx:test_support",
73 "//url", 77 "//url",
74 ] 78 ]
75 } 79 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698