Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2721333005: Reauthorize Keychain to Replace Developer ID Certificate (Closed)
Patch Set: Cleanup the comments, and error handling logic Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« chrome/browser/mac/keychain_reauthorize.mm ('K') | « components/os_crypt/keychain_password_mac.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index fee8ffc8bb175ebd7ce9905906e441235296b34c..b06d4ede7dd04896d1c8d6b22d0d3fd01e90652c 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -43746,6 +43746,41 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="OSX.KeychainReauthorizeIfNeeded" units="count">
+ <owner>kerrnel@chromium.org</owner>
+ <owner>mark@chromium.org</owner>
+ <summary>
+ The number of previous times that the keychain reauthorization did not
+ complete.
Ilya Sherman 2017/03/03 01:36:12 Please document when this is recorded. Ditto for
Greg K 2017/03/03 18:18:03 Done.
+ </summary>
+</histogram>
+
+<histogram name="OSX.KeychainReauthorizeIfNeededAtUpdate" units="count">
+ <owner>kerrnel@chromium.org</owner>
+ <owner>mark@chromium.org</owner>
+ <summary>
+ The number of previous times that the keychain reauthorization did not
+ complete, when run at update time.
+ </summary>
+</histogram>
+
+<histogram name="OSX.KeychainReauthorizeIfNeededAtUpdateSuccess" units="count">
+ <owner>kerrnel@chromium.org</owner>
+ <owner>mark@chromium.org</owner>
+ <summary>
+ How many times the keychain reauthorization ran before finally succeeding,
+ when run at update time.
+ </summary>
+</histogram>
+
+<histogram name="OSX.KeychainReauthorizeIfNeededSuccess" units="count">
+ <owner>kerrnel@chromium.org</owner>
+ <owner>mark@chromium.org</owner>
+ <summary>
+ How many times the keychain reauthorization ran before finally succeeding.
Ilya Sherman 2017/03/03 01:36:12 This metric counts runs that are not at update tim
Greg K 2017/03/03 18:18:04 Done.
+ </summary>
+</histogram>
+
<histogram name="OSX.RendererHost.SurfaceWaitTime" units="ms">
<obsolete>
Deprecated as of 11/2015.
« chrome/browser/mac/keychain_reauthorize.mm ('K') | « components/os_crypt/keychain_password_mac.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698