tools/mb/mb.py - Issue 2721323003: Record screenshots on failures on swarming bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/mb/mb.py

Issue 2721323003: Record screenshots on failures on swarming bots. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/mb/mb.py

diff --git a/tools/mb/mb.py b/tools/mb/mb.py

index 917f3c62be301aad351cf8234a38bbb2d46ee84a..7652f2a9a87dfee3597ad0f215480bd0dc40ab61 100755

--- a/tools/mb/mb.py

+++ b/tools/mb/mb.py

@@ -1091,6 +1091,7 @@ class MetaBuildWrapper(object):

cmdline = [

self.PathJoin('bin', 'run_%s' % target),

'--logcat-output-file', '${ISOLATED_OUTDIR}/logcats',

+ '--screenshot-dir', '$(mktemp -d)',

jbudorick 2017/03/01 20:19:21 I don't think we ought to pass this for anything b

bpastene 2017/03/01 20:35:54 You could add the arg to all instrumentation tests

jbudorick 2017/03/01 20:45:39 Ideally, this would be less tedious once we're gen

'--target-devices-file', '${SWARMING_BOT_FILE}',

'-v'

]

« build/android/test_runner.py ('K') | « build/android/test_runner.py ('k') | no next file » | no next file with comments »