Record screenshots on failures on swarming bots.

build/android/pylib/local/device/local_device_instrumentation_test_run.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 import os
 import posixpath
 import re
 import tempfile
 import time
@@ skipping 352 matching lines @@
         if r.GetType() == base_test_result.ResultType.UNKNOWN:
           r.SetType(base_test_result.ResultType.CRASH)
 
     # Handle failures by:
     #   - optionally taking a screenshot
     #   - logging the raw output at INFO level
     #   - clearing the application state while persisting permissions
     if any(r.GetType() not in (base_test_result.ResultType.PASS,
                                base_test_result.ResultType.SKIP)
            for r in results):
-      if self._test_instance.screenshot_dir:
-        file_name = '%s-%s.png' % (
-            test_display_name,
-            time.strftime('%Y%m%dT%H%M%S', time.localtime()))
-        screenshot_file = device.TakeScreenshot(
-            os.path.join(self._test_instance.screenshot_dir, file_name))
-        logging.info(
-            'Saved screenshot for %s to %s.',
-            test_display_name, screenshot_file)
-        if self._test_instance.should_save_images:
-          link = google_storage_helper.upload(
-              google_storage_helper.unique_name('screenshot', device=device),
-              screenshot_file,
-              bucket='chromium-render-tests')
-          for result in results:
-            result.SetLink('failure_screenshot', link)
+
+      with contextlib_ext.Optional(
+          tempfile_ext.NamedTemporaryDirectory(),
+          self._test_instance.screenshot_dir is None
+          and self._test_instance.should_save_images) as screenshot_dir:
+
+        screenshot_dir = self._test_instance.screenshot_dir or screenshot_dir
+        if screenshot_dir:
+          file_name = '%s-%s.png' % (
+              test_display_name,
+              time.strftime('%Y%m%dT%H%M%S', time.localtime()))
+          screenshot_file = device.TakeScreenshot(
+              os.path.join(self._test_instance.screenshot_dir, file_name))
+          logging.info(
+              'Saved screenshot for %s to %s.',
+              test_display_name, screenshot_file)
+          if self._test_instance.should_save_images:
+            link = google_storage_helper.upload(
+                google_storage_helper.unique_name('screenshot', device=device),
+                screenshot_file,
+                bucket='chromium-render-tests')
+            for result in results:
+              result.SetLink('failure_screenshot', link)
 
       logging.info('detected failure in %s. raw output:', test_display_name)
       for l in output:
         logging.info('  %s', l)
       if (not self._env.skip_clear_data
           and self._test_instance.package_info):
         permissions = (
             self._test_instance.apk_under_test.GetPermissions()
             if self._test_instance.apk_under_test
             else None)
@@ skipping 144 matching lines @@
         timeout = v
         break
     else:
       logging.warning('Using default 1 minute timeout for %s', test_name)
       timeout = 60
 
     timeout *= cls._GetTimeoutScaleFromAnnotations(annotations)
 
     return timeout