Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: chrome/browser/android/offline_pages/recent_tab_helper.cc

Issue 2721253002: Last_n: Add instrumentation test for the tab closure case. (Closed)
Patch Set: Comment changes. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/RecentTabsTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/offline_pages/recent_tab_helper.cc
diff --git a/chrome/browser/android/offline_pages/recent_tab_helper.cc b/chrome/browser/android/offline_pages/recent_tab_helper.cc
index 191754d8f56833e26d8c2f413394db8cecaa924f..01c2011e17a8c6766b0d4c0224837d5049eed7f4 100644
--- a/chrome/browser/android/offline_pages/recent_tab_helper.cc
+++ b/chrome/browser/android/offline_pages/recent_tab_helper.cc
@@ -261,9 +261,6 @@ void RecentTabHelper::WebContentsDestroyed() {
CancelInFlightSnapshots();
}
-// TODO(carlosk): this method is also called when the tab is being closed, when
-// saving a snapshot is probably useless (low probability of the user undoing
-// the close). We should detect that and avoid the saving.
void RecentTabHelper::WasHidden() {
if (!IsOffliningRecentPagesEnabled())
return;
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/RecentTabsTest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698